Skip to content

Add fraud proof gossiping logic to light clients#724

Merged
tzdybal merged 3 commits intomainfrom
tzdybal/light-stub
Feb 3, 2023
Merged

Add fraud proof gossiping logic to light clients#724
tzdybal merged 3 commits intomainfrom
tzdybal/light-stub

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Feb 1, 2023

Resolves #673.

@tzdybal tzdybal added C:light-client C:state-fraud-proofs Component: State Fraud Proofs (generation and validation) labels Feb 1, 2023
@tzdybal tzdybal self-assigned this Feb 1, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 1, 2023

Codecov Report

Base: 55.15% // Head: 54.83% // Decreases project coverage by -0.32% ⚠️

Coverage data is based on head (bf29388) compared to base (b82de97).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   55.15%   54.83%   -0.32%     
==========================================
  Files          52       52              
  Lines        9755     9816      +61     
==========================================
+ Hits         5380     5383       +3     
- Misses       3577     3636      +59     
+ Partials      798      797       -1     
Impacted Files Coverage Δ
node/full.go 61.96% <0.00%> (ø)
node/light.go 0.00% <0.00%> (ø)
node/node.go 52.38% <0.00%> (-26.20%) ⬇️
block/manager.go 63.63% <0.00%> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tzdybal tzdybal changed the title Tzdybal/light stub Add fraud proof gossiping logic to llight clients Feb 1, 2023
@tzdybal tzdybal changed the title Add fraud proof gossiping logic to llight clients Add fraud proof gossiping logic to light clients Feb 1, 2023
@tzdybal tzdybal marked this pull request as ready for review February 2, 2023 10:20
@tzdybal tzdybal requested review from a team, Manav-Aggarwal, S1nus, nashqueue and tuxcanfly and removed request for a team February 2, 2023 10:20
Copy link
Copy Markdown
Member

@Manav-Aggarwal Manav-Aggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes in bf29388, otherwise, LGTM.

@tzdybal tzdybal merged commit 9563c74 into main Feb 3, 2023
@tzdybal tzdybal deleted the tzdybal/light-stub branch February 3, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:light-client C:state-fraud-proofs Component: State Fraud Proofs (generation and validation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Fraud Proof gossiping to light node

4 participants