Skip to content

Lazy Sequencer#760

Merged
nashqueue merged 11 commits intomainfrom
connor/lazy-sequencer
Mar 15, 2023
Merged

Lazy Sequencer#760
nashqueue merged 11 commits intomainfrom
connor/lazy-sequencer

Conversation

@S1nus
Copy link
Copy Markdown
Contributor

@S1nus S1nus commented Mar 7, 2023

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage: 95.94% and project coverage change: +0.04 🎉

Comparison is base (f7d95c2) 55.27% compared to head (db11095) 55.31%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
+ Coverage   55.27%   55.31%   +0.04%     
==========================================
  Files          53       53              
  Lines       10000    10035      +35     
==========================================
+ Hits         5527     5551      +24     
- Misses       3652     3659       +7     
- Partials      821      825       +4     
Impacted Files Coverage Δ
state/executor.go 64.73% <ø> (-0.73%) ⬇️
block/manager.go 66.24% <94.00%> (+1.84%) ⬆️
config/config.go 90.32% <100.00%> (+0.66%) ⬆️
node/full.go 61.22% <100.00%> (+0.48%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread block/manager.go Outdated
gupadhyaya
gupadhyaya previously approved these changes Mar 8, 2023
Copy link
Copy Markdown
Contributor

@gupadhyaya gupadhyaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from minor comment, LTGM.

Comment thread block/manager.go Outdated
Comment thread block/manager.go
Comment thread block/manager_test.go
Comment thread state/executor.go Outdated
Comment thread node/full_node_integration_test.go
@nashqueue
Copy link
Copy Markdown
Contributor

nashqueue commented Mar 8, 2023

General feedback: If you open a PR, please assign it to yourself; write in the description which issue it closes and what labels are appropriate. Tbh this is a good opportunity for automation.

Comment thread block/manager.go Outdated
Comment thread block/manager.go Outdated
@S1nus S1nus requested review from gupadhyaya and nashqueue March 13, 2023 17:50
Comment thread block/manager.go Outdated
Comment thread block/manager.go Outdated
Comment thread config/defaults.go
gupadhyaya
gupadhyaya previously approved these changes Mar 13, 2023
Copy link
Copy Markdown
Contributor

@gupadhyaya gupadhyaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments. otherwise lgtm.

Copy link
Copy Markdown
Contributor

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , Please address the questions i had, even if they are non-blocking.

@nashqueue nashqueue merged commit 58681cc into main Mar 15, 2023
@nashqueue nashqueue deleted the connor/lazy-sequencer branch March 15, 2023 14:42
nashqueue pushed a commit that referenced this pull request Apr 10, 2023
Co-authored-by: Connor O'Hara <connor@switchboard.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants