Skip to content

adds soft confirmations to dependency graph#774

Merged
nashqueue merged 6 commits intomainfrom
soft-conf-dep-graph
Mar 21, 2023
Merged

adds soft confirmations to dependency graph#774
nashqueue merged 6 commits intomainfrom
soft-conf-dep-graph

Conversation

@S1nus
Copy link
Copy Markdown
Contributor

@S1nus S1nus commented Mar 13, 2023

Goal of soft-confirmations is to enable a fast UX comparable to other rollups and alt-L1s on the market, as soon as possible, with the goal of eventually being fully compatible with light clients.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.21 ⚠️

Comparison is base (8eb79aa) 55.15% compared to head (4b01f9e) 54.94%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
- Coverage   55.15%   54.94%   -0.21%     
==========================================
  Files          53       54       +1     
  Lines       10000     9904      -96     
==========================================
- Hits         5515     5442      -73     
- Misses       3660     3666       +6     
+ Partials      825      796      -29     

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nashqueue
Copy link
Copy Markdown
Contributor

nashqueue commented Mar 13, 2023

Could you incorporate the soft commitments that are already in the graph? The left-most yellow box is soft commitments. Could you also differentiate between LN soft commitments through headers and FN soft commitments through blocks?

@S1nus S1nus marked this pull request as ready for review March 15, 2023 16:11
Copy link
Copy Markdown
Contributor

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Copy link
Copy Markdown
Contributor

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nashqueue nashqueue force-pushed the soft-conf-dep-graph branch from 7117802 to 44fdfdd Compare March 21, 2023 15:19
@nashqueue nashqueue enabled auto-merge (squash) March 21, 2023 15:20
Copy link
Copy Markdown
Collaborator

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@nashqueue nashqueue merged commit 1104628 into main Mar 21, 2023
@nashqueue nashqueue deleted the soft-conf-dep-graph branch March 21, 2023 15:23
@nashqueue nashqueue added the T:documentation Improvements or additions to documentation label Mar 21, 2023
nashqueue pushed a commit that referenced this pull request Apr 10, 2023
Goal of soft-confirmations is to enable a fast UX comparable to other
rollups and alt-L1s on the market, as soon as possible, with the goal of
eventually being fully compatible with light clients.

---------

Co-authored-by: Connor O'Hara <connor@switchboard.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants