Skip to content

Remove sequencer gossip#786

Merged
nashqueue merged 6 commits intoevstack:mainfrom
gupadhyaya:remove_sequencer_gossip3
Mar 16, 2023
Merged

Remove sequencer gossip#786
nashqueue merged 6 commits intoevstack:mainfrom
gupadhyaya:remove_sequencer_gossip3

Conversation

@gupadhyaya
Copy link
Copy Markdown
Contributor

Fixes #781

@gupadhyaya gupadhyaya force-pushed the remove_sequencer_gossip3 branch from 12d5be1 to f29f20e Compare March 15, 2023 20:07
@gupadhyaya gupadhyaya changed the title Remove sequencer gossip3 Remove sequencer gossip Mar 15, 2023
@nashqueue nashqueue added this to the Go-header implementation milestone Mar 15, 2023
tuxcanfly
tuxcanfly previously approved these changes Mar 15, 2023
Copy link
Copy Markdown
Collaborator

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with minor nit.

Comment thread types/signed_header.go
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage: 74.72% and project coverage change: -0.21 ⚠️

Comparison is base (f7d95c2) 55.27% compared to head (aa3f379) 55.06%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   55.27%   55.06%   -0.21%     
==========================================
  Files          53       54       +1     
  Lines       10000     9904      -96     
==========================================
- Hits         5527     5454      -73     
- Misses       3652     3657       +5     
+ Partials      821      793      -28     
Impacted Files Coverage Δ
node/light.go 0.00% <0.00%> (ø)
types/pb/rollkit/rollkit.pb.go 38.77% <21.31%> (-1.62%) ⬇️
types/signed_header.go 52.38% <52.38%> (ø)
state/executor.go 65.62% <89.18%> (+0.16%) ⬆️
block/manager.go 67.27% <94.59%> (+2.87%) ⬆️
node/header_exchange.go 51.96% <95.00%> (+0.47%) ⬆️
config/config.go 90.32% <100.00%> (+0.66%) ⬆️
conv/abci/block.go 94.33% <100.00%> (ø)
da/mock/mock.go 73.75% <100.00%> (ø)
node/full.go 63.18% <100.00%> (+2.43%) ⬆️
... and 5 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@nashqueue nashqueue enabled auto-merge (squash) March 16, 2023 09:55
@nashqueue nashqueue force-pushed the remove_sequencer_gossip3 branch from aa3f379 to d1a4213 Compare March 16, 2023 10:05
Copy link
Copy Markdown
Collaborator

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@nashqueue nashqueue merged commit 4624443 into evstack:main Mar 16, 2023
nashqueue pushed a commit that referenced this pull request Apr 10, 2023
Fixes #781

---------

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge Heraderexchange and remove current gossip

4 participants