Skip to content

deps: bump go-header#800

Merged
gupadhyaya merged 5 commits intoevstack:mainfrom
Wondertan:hlib/bump-go-header
Mar 27, 2023
Merged

deps: bump go-header#800
gupadhyaya merged 5 commits intoevstack:mainfrom
Wondertan:hlib/bump-go-header

Conversation

@Wondertan
Copy link
Copy Markdown
Contributor

Depends on #799

Unifies VerifyAdjacent and VerifyNonAdjacent into Verify

@Wondertan
Copy link
Copy Markdown
Contributor Author

@gupadhyaya, what was the test where we had to put sleep? We can now remove it, as the core problem is now fixed.

Comment thread types/header.go
@Wondertan Wondertan changed the title deps: bump libp2p deps: bump go-header Mar 23, 2023
@Wondertan Wondertan force-pushed the hlib/bump-go-header branch from ad5b7ed to faf8d80 Compare March 23, 2023 11:32
@Wondertan Wondertan marked this pull request as ready for review March 23, 2023 11:32
@nashqueue
Copy link
Copy Markdown
Contributor

nashqueue commented Mar 23, 2023

@gupadhyaya, what was the test where we had to put sleep? We can now remove it, as the core problem is now fixed.

@Wondertan https://github.com/rollkit/rollkit/blob/main/node/full_node_integration_test.go#L215 and 4 following tests

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2023

Codecov Report

Patch coverage: 54.83% and project coverage change: -0.07 ⚠️

Comparison is base (c6d3972) 54.85% compared to head (26f447d) 54.79%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
- Coverage   54.85%   54.79%   -0.07%     
==========================================
  Files          54       54              
  Lines       10231    10206      -25     
==========================================
- Hits         5612     5592      -20     
+ Misses       3787     3782       -5     
  Partials      832      832              
Impacted Files Coverage Δ
types/header.go 39.28% <23.07%> (-6.29%) ⬇️
types/signed_header.go 66.66% <40.00%> (+14.28%) ⬆️
node/header_exchange.go 54.47% <92.30%> (+2.50%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wondertan
Copy link
Copy Markdown
Contributor Author

@nashqueue, cool. Let's merge this one, and I will make a separate PR/commit to remove those timeouts.

tuxcanfly
tuxcanfly previously approved these changes Mar 23, 2023
Copy link
Copy Markdown
Collaborator

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Comment thread types/header.go
Comment thread types/signed_header.go
Comment thread types/signed_header.go
Comment thread node/header_exchange.go Outdated
@tuxcanfly tuxcanfly force-pushed the hlib/bump-go-header branch from 62a8bbb to 1bc49d6 Compare March 24, 2023 13:31
@Wondertan
Copy link
Copy Markdown
Contributor Author

@tuxcanfly, why force push?

@tuxcanfly
Copy link
Copy Markdown
Collaborator

@Wondertan it required a rebase with the main branch to merge.

@Wondertan
Copy link
Copy Markdown
Contributor Author

Ok, thanks for taking this and next time pls coordinate with me 🙏🏻

Copy link
Copy Markdown
Collaborator

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@gupadhyaya gupadhyaya merged commit 2efe202 into evstack:main Mar 27, 2023
nashqueue pushed a commit that referenced this pull request Apr 10, 2023
Depends on #799 

Unifies `VerifyAdjacent` and `VerifyNonAdjacent` into `Verify`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants