Skip to content

Bug fix: lazy aggregator#803

Merged
nashqueue merged 7 commits intomainfrom
connor/fix-lazy-agg
Mar 24, 2023
Merged

Bug fix: lazy aggregator#803
nashqueue merged 7 commits intomainfrom
connor/fix-lazy-agg

Conversation

@S1nus
Copy link
Copy Markdown
Contributor

@S1nus S1nus commented Mar 23, 2023

fixes this
#802

@S1nus S1nus marked this pull request as ready for review March 23, 2023 17:04
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (770a9bd) 54.74% compared to head (72d9d59) 54.81%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   54.74%   54.81%   +0.07%     
==========================================
  Files          54       54              
  Lines       10232    10231       -1     
==========================================
+ Hits         5601     5608       +7     
+ Misses       3796     3790       -6     
+ Partials      835      833       -2     
Impacted Files Coverage Δ
block/manager.go 65.38% <ø> (+0.59%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@Manav-Aggarwal Manav-Aggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Mar 24, 2023

:shipit:

Copy link
Copy Markdown
Contributor

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nashqueue nashqueue merged commit c6d3972 into main Mar 24, 2023
@nashqueue nashqueue deleted the connor/fix-lazy-agg branch March 24, 2023 11:03
nashqueue pushed a commit that referenced this pull request Apr 10, 2023
fixes this
#802

---------

Co-authored-by: Connor O'Hara <connor@switchboard.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants