test: improved test robustness#320
Merged
UlisesGascon merged 1 commit intoexpressjs:masterfrom Oct 7, 2024
Merged
Conversation
UlisesGascon
approved these changes
Sep 11, 2024
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! Thanks for preparing the PR @Alex-GF ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses an issue regarding the testing of the handling and generation of
Access-Control-Allow-Headersheader. Through the application of mutation testing, I have identified a potential mutation in the configuration logic that was not covered by the existing tests (issue fully explain in this threat).Proposed Change
To mitigate this, I suggest changing the assertion method from
assert.equaltoassert.strictEqualin thetest/test.jsfile, specifically at line 444. This alteration would ensure that the tests verify not only the value but also the exact type of the header content, thereby preventing potential type coercion issues.Additional Information
This Pull Request has been created following the directions of @UlisesGascon.
Looking forward to your feedback and approval.
Thank you for considering this enhancement.
Best regards.
Edited by @UlisesGascon
closes #319