Merged
Conversation
tomaszszopinski
requested review from
bogusez,
kacper-wieczorek-ibexa,
micszo,
mnocon and
pbisaga
mnocon
approved these changes
Nov 17, 2021
Member
mnocon
left a comment
mnocon
left a comment
There was a problem hiding this comment.
Looks good! Just please remember to run CS-fixer and all checks should be green.
pbisaga
approved these changes
Nov 17, 2021
bogusez
suggested changes
Nov 17, 2021
| $this->contentTypeHasField($contentTypeName, $row['fieldName'], $row['fieldType']); | ||
| } | ||
| } | ||
|
|
| public function getFieldDefinitionContainerLocator(string $containerName): string | ||
| { | ||
| $containerIndex = $this->context->getElementPositionByText($containerName, $this->fields['fieldDefinitionName']); | ||
|
|
bogusez
approved these changes
Nov 17, 2021
tomaszszopinski
changed the title
micszo
approved these changes
Nov 17, 2021
cs fix additional cs-fixes
tomaszszopinski
force-pushed
the
ibx-1289-admin-ui-backport
branch
from
eb13240 to
e561f26
Compare
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.ibexa.co/browse/IBX-1289
Related PR: https://github.com/ezsystems/ezplatform-page-builder/pull/904
This is the backport of https://issues.ibexa.co/browse/IBX-1070 & https://issues.ibexa.co/browse/IBX-671.