[0.26.0-rc] autocorrect broken

[sjmueller]

When setting up a TextInput to keep in sync with state (as per documentation), autocorrect breaks. For example:

<TextInput
  style={styles.title}
  placeholder="Title"
  onChangeText={title => this.setState({title})}
  value={this.state.title}
/>

It seems that the value of the native control is now getting overridden during every onChangeText event that updates state, because even things like double space no longer results in a period.

For reference, I'm also on react 15.0.2

[sjmueller]

Did some investigation, and found this commit:

Fix autocomplete in rich-text editing mode for CJK text input 91dcc9a

I rolled these changes out of my build, but still looks like the same problems persist. Any suggestions?

[mpretty-cyro]

@sjmueller It looks like the 'setText:' method of RCTTextField is getting called twice, once with the old value then again with the new value. Having it set twice is what is causing the problem.

[mpretty-cyro]

Actually, it looks like the problem is this if statement

react-native/Libraries/Components/TextInput/TextInput.js

Line 619 in dd8caf4

if (text !== this.props.value && typeof this.props.value === 'string') {

[mpretty-cyro]

@nicklockwood It seems to me that autocorrect could never work if the TextInput is a controlled component. Unfortunately I can't think of a nice way to fix this without having something return that the text change is valid and hence shouldn't call setNativeProps. Do you have any ideas which might help?

[mpretty-cyro]

@sjmueller I've created a PR which seems to fix the autocorrect on iOS (haven't tested the effects on Android yet). If you decide to try it out then let me know if this introduces any bug.

[rigdern]

This is a regression caused by a change to batch event handling in React Native: facebook/react@9f11f8c

cc @spicyj

[sophiebits]

Not at a computer, but you can look at a recent change I did to PickerAndroid to fix a similar issue.

[rigdern]

@nicklockwood Should this issue be closed since you merged my PR? 26aa27d

[mpretty-cyro]

I can confirm the 26aa27d fix works for me as well.