Fix normalization of degrees in AnimatedInterpolation#36645
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Fix normalization of degrees in AnimatedInterpolation#36645javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44406034 |
Base commit: 32e836d |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44406034 |
javache
force-pushed
the
export-D44406034
branch
from
dcf8867 to
53a0064
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44406034 |
javache
force-pushed
the
export-D44406034
branch
from
53a0064 to
0ce0d96
Compare
Summary: Pull Request resolved: facebook#36645 This broke while changing the AnimatedInterpolation back in D40571873 and D40632443, as I assumed the native side would be able to correctly handle values such as '1rad'. However these were being sent over as strings, and were thus using the string interpolation path, which does not work here. Instead, handle both `deg` and `rad` explicitly when generating the config in JS. Resolves issue facebook#36608 Changelog: [General][Fixed] Resolves Animated.Value.interpolate results in NaN when output is in radians Reviewed By: yungsters Differential Revision: D44406034 fbshipit-source-id: ea0eec9421b91d200024371696d4d2406a4f8767
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44406034 |
javache
force-pushed
the
export-D44406034
branch
from
0ce0d96 to
8fe0c50
Compare
Contributor
|
This pull request has been merged in ae0d714. |
fortmarek
pushed a commit
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: #36645 This broke while changing the AnimatedInterpolation back in D40571873 and D40632443, as I assumed the native side would be able to correctly handle values such as '1rad'. However these were being sent over as strings, and were thus using the string interpolation path, which does not work here. Instead, handle both `deg` and `rad` explicitly when generating the config in JS. Resolves issue #36608 Changelog: [General][Fixed] Resolves Animated.Value.interpolate results in NaN when output is in radians Reviewed By: yungsters Differential Revision: D44406034 fbshipit-source-id: fe0f3df16f2b8ec6c31f9359e4706cacc72b9951
This was referenced Jan 4, 2024
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This broke while changing the AnimatedInterpolation back in D40571873 and D40632443, as I assumed the native side would be able to correctly handle values such as '1rad'. However these were being sent over as strings, and were thus using the string interpolation path, which does not work here.
Instead, handle both
degandradexplicitly when generating the config in JS.Resolves issue #36608
Changelog: [General][Fixed] Resolves Animated.Value.interpolate results in NaN when output is in radians
Differential Revision: D44406034