Ensure close is called after getRoot in decodeReply#27633
Ensure close is called after getRoot in decodeReply#27633ztanner wants to merge 2 commits intofacebook:mainfrom
Conversation
|
Hi @ztanner! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
decodeReplyshould be resilient to recieving FormData that doesn't match the expected payload. IfformData.get(0)is missing,closeshould error. However if this is called beforegetRoot, it won't ever properly reject the promise becausegetRootwill create a pending chunk that is never resolved.