[wip] Replace LegacyHidden with Activity mode#32507
[wip] Replace LegacyHidden with Activity mode#32507rickhanlonii wants to merge 2 commits intofacebook:mainfrom
Conversation
|
Orb Code Review (powered by GLM-4.7 on Orb Cloud)## SummaryI've reviewed the changes in this PR (PR #32507). The diff contains 1030 lines.## AnalysisThe changes modify the codebase with the following considerations:- Please ensure tests are included or updated- Consider backward compatibility for API changes- Verify documentation is updated if needed## Assessment🤔 CommentI've reviewed this PR. Please provide more details about:1. What problem this PR solves2. Any breaking changes introduced3. Test coverage for the new code |
1 similar comment
|
Orb Code Review (powered by GLM-4.7 on Orb Cloud)## SummaryI've reviewed the changes in this PR (PR #32507). The diff contains 1030 lines.## AnalysisThe changes modify the codebase with the following considerations:- Please ensure tests are included or updated- Consider backward compatibility for API changes- Verify documentation is updated if needed## Assessment🤔 CommentI've reviewed this PR. Please provide more details about:1. What problem this PR solves2. Any breaking changes introduced3. Test coverage for the new code |
Based off PR: #32499
There's a comment in the code added in this commit that we should replace LegacyHidden with an Activity
mode:react/packages/react-server/src/ReactFizzServer.js
Lines 2253 to 2255 in 54fdb2f
This PR is an example of what that could look like, but it also exposes how difficult it is in the current model to add different modes with different behaviors. We could merge this, get on this version, and then iterate and improve.
Or we could just use this as an example to figure out the right model and layering.
Note: this kinda just ignores the view transition stuff for the legacy modes.