[eprh] Fix exhaustive-deps not detecting function parameter assignment#34771
[eprh] Fix exhaustive-deps not detecting function parameter assignment#34771k-yle wants to merge 1 commit intofacebook:mainfrom
exhaustive-deps not detecting function parameter assignment#34771Conversation
| /** | ||
| * A string template tag that removes padding from the left side of multi-line strings | ||
| * @param {Array} strings array of code strings (only one expected) | ||
| * @param {TemplateStringsArray} strings array of code strings (only one expected) |
There was a problem hiding this comment.
this change is unrelated. It fixes the 400+ typescript errors in this file
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
not stale, still a bug... |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
not stale, just waiting for a code review. bug still exists |
Summary
Closes #20248
exhaustive-depsalready detects this case:but not this case:
nor this case:
This PR makes the rule detect both of these new cases.
How did you test this change?
yarn test