[Compiler] Don't count a setState in the dependency array of the effect it is called on as a usage by jorge-cab · Pull Request #35134 · facebook/react

jorge-cab · 2025-11-13T23:50:48Z

Summary:
The validation only allows setState declaration as a usage outside of the effect.

Another edge case is that if you add the setState being validated in the dependency array you also make the validation opt out since it counts as a usage outside of the effect.

Added a bit of logic to consider the effect's deps when creating the cache for setState usages within the effect

Test Plan:
Added a fixture

Stack created with Sapling. Best reviewed with ReviewStack.

[Compiler] Avoid capturing global setStates for no-derived-computations lint #35135
-> [Compiler] Don't count a setState in the dependency array of the effect it is called on as a usage #35134

…ct it is called on as a usage Summary: The validation only allows setState declaration as a usage outside of the effect. Another edge case is that if you add the setState being validated in the dependency array you also make the validation opt out since it counts as a usage outside of the effect. Added a bit of logic to consider the effect's deps when creating the cache for setState usages within the effect Test Plan: Added a fixture

josephsavona · 2025-11-14T00:49:24Z

+function Component({prop}) {
+  const [s, setS] = useState(0);
+  useEffect(() => {
+    setS(prop);
+  }, [prop, setS]);


nit: maybe pass the setState down in props that way it's reactive and has to be included as a dep?

That would disallow the lint as per the next diff 😅 might have to keep it like this in the short term

…ns lint (#35135) Summary: This only matters when enableTreatSetIdentifiersAsStateSetters=true This pattern is still bad. But Right now the validation can only recommend to move stuff to "calculate in render" A global setState should not be moved to render, not even conditionally and you can't remove state without crossing Component boundaries, which makes this a different kind of fix. So while we are only suggesting "calculate in render" as a fix we should disallow the lint from throwing in this case IMO Test Plan: Added a fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35135). * __->__ #35135 * #35134

…ct it is called on as a usage (#35134) Summary: The validation only allows setState declaration as a usage outside of the effect. Another edge case is that if you add the setState being validated in the dependency array you also make the validation opt out since it counts as a usage outside of the effect. Added a bit of logic to consider the effect's deps when creating the cache for setState usages within the effect Test Plan: Added a fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35134). * #35135 * __->__ #35134 DiffTrain build for [de97ef9](de97ef9)

…ns lint (#35135) Summary: This only matters when enableTreatSetIdentifiersAsStateSetters=true This pattern is still bad. But Right now the validation can only recommend to move stuff to "calculate in render" A global setState should not be moved to render, not even conditionally and you can't remove state without crossing Component boundaries, which makes this a different kind of fix. So while we are only suggesting "calculate in render" as a fix we should disallow the lint from throwing in this case IMO Test Plan: Added a fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35135). * __->__ #35135 * #35134 DiffTrain build for [257b033](257b033)

…ct it is called on as a usage (facebook#35134) Summary: The validation only allows setState declaration as a usage outside of the effect. Another edge case is that if you add the setState being validated in the dependency array you also make the validation opt out since it counts as a usage outside of the effect. Added a bit of logic to consider the effect's deps when creating the cache for setState usages within the effect Test Plan: Added a fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35134). * facebook#35135 * __->__ facebook#35134

…ns lint (facebook#35135) Summary: This only matters when enableTreatSetIdentifiersAsStateSetters=true This pattern is still bad. But Right now the validation can only recommend to move stuff to "calculate in render" A global setState should not be moved to render, not even conditionally and you can't remove state without crossing Component boundaries, which makes this a different kind of fix. So while we are only suggesting "calculate in render" as a fix we should disallow the lint from throwing in this case IMO Test Plan: Added a fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35135). * __->__ facebook#35135 * facebook#35134

[diff facebook/react@93fc5740...fb2177c1](facebook/react@93fc574...fb2177c) <details> <summary>React upstream changes</summary> - facebook/react#35143 - facebook/react#35145 - facebook/react#35140 - facebook/react#35139 - facebook/react#35062 - facebook/react#35135 - facebook/react#35134 </details>

…ns lint (facebook#35135) Summary: This only matters when enableTreatSetIdentifiersAsStateSetters=true This pattern is still bad. But Right now the validation can only recommend to move stuff to "calculate in render" A global setState should not be moved to render, not even conditionally and you can't remove state without crossing Component boundaries, which makes this a different kind of fix. So while we are only suggesting "calculate in render" as a fix we should disallow the lint from throwing in this case IMO Test Plan: Added a fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35135). * __->__ facebook#35135 * facebook#35134 DiffTrain build for [257b033](facebook@257b033)

This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | devDependencies | minor | [`8.58.2` → `8.59.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.58.2/8.59.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | devDependencies | minor | [`8.58.2` → `8.59.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.58.2/8.59.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [ajv](https://ajv.js.org) ([source](https://github.com/ajv-validator/ajv)) | dependencies | minor | [`8.18.0` → `8.20.0`](https://renovatebot.com/diffs/npm/ajv/8.18.0/8.20.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/ajv-validator/ajv/badge)](https://securityscorecards.dev/viewer/?uri=github.com/ajv-validator/ajv) | | [eslint-plugin-react-hooks](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks)) | devDependencies | minor | [`7.0.1` → `7.1.1`](https://renovatebot.com/diffs/npm/eslint-plugin-react-hooks/7.0.1/7.1.1) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/facebook/react/badge)](https://securityscorecards.dev/viewer/?uri=github.com/facebook/react) | | [react-toastify](https://github.com/fkhadra/react-toastify) | dependencies | minor | [`11.0.5` → `11.1.0`](https://renovatebot.com/diffs/npm/react-toastify/11.0.5/11.1.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/fkhadra/react-toastify/badge)](https://securityscorecards.dev/viewer/?uri=github.com/fkhadra/react-toastify) | | [typescript-eslint](https://typescript-eslint.io/packages/typescript-eslint) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint)) | devDependencies | minor | [`8.58.2` → `8.59.0`](https://renovatebot.com/diffs/npm/typescript-eslint/8.58.2/8.59.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/typescript-eslint/typescript-eslint/badge)](https://securityscorecards.dev/viewer/?uri=github.com/typescript-eslint/typescript-eslint) | | [vite-plugin-static-copy](https://github.com/sapphi-red/vite-plugin-static-copy) | devDependencies | minor | [`4.0.1` → `4.1.0`](https://renovatebot.com/diffs/npm/vite-plugin-static-copy/4.0.1/4.1.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/sapphi-red/vite-plugin-static-copy/badge)](https://securityscorecards.dev/viewer/?uri=github.com/sapphi-red/vite-plugin-static-copy) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v8.59.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8590-2026-04-20) [Compare Source](typescript-eslint/typescript-eslint@v8.58.2...v8.59.0) ##### 🚀 Features - **eslint-plugin:** \[no-unnecessary-type-assertion] report more cases based on assignability ([#11789](typescript-eslint/typescript-eslint#11789)) ##### ❤️ Thank You - Ulrich Stark See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.59.0) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v8.59.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8590-2026-04-20) [Compare Source](typescript-eslint/typescript-eslint@v8.58.2...v8.59.0) This was a version bump only for parser to align it with other projects, there were no code changes. See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.59.0) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>ajv-validator/ajv (ajv)</summary> ### [`v8.20.0`](https://github.com/ajv-validator/ajv/releases/tag/v8.20.0) [Compare Source](ajv-validator/ajv@v8.18.0...v8.20.0) #### What's Changed - fix: add support for node 22/24, drop node 16/21 by [@jasoniangreen](https://github.com/jasoniangreen) in [#2580](ajv-validator/ajv#2580) - fix: add ES2022.RegExp for RegExpIndicesArray by [@SignpostMarv](https://github.com/SignpostMarv) in [#2604](ajv-validator/ajv#2604) **Full Changelog**: <ajv-validator/ajv@v8.19.0...v8.20.0> </details> <details> <summary>facebook/react (eslint-plugin-react-hooks)</summary> ### [`v7.1.1`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#711) [Compare Source](https://github.com/facebook/react/compare/eslint-plugin-react-hooks@7.1.0...eslint-plugin-react-hooks@7.1.1) **Note:** 7.1.0 accidentally removed the `component-hook-factories` rule, causing errors for users who referenced it in their ESLint config. This is now fixed. - Add deprecated no-op `component-hook-factories` rule for backwards compatibility. ([@mofeiZ](https://github.com/mofeiZ) in [#36307](facebook/react#36307)) ### [`v7.1.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#710) [Compare Source](https://github.com/facebook/react/compare/408b38ef7304faf022d2a37110c57efce12c6bad...eslint-plugin-react-hooks@7.1.0) This release adds ESLint v10 support, improves performance by skipping compilation for non-React files, and includes compiler lint improvements including better `set-state-in-effect` detection, improved ref validation, and more helpful error reporting. - Add ESLint v10 support. ([@azat-io](https://github.com/azat-io) in [#35720](facebook/react#35720)) - Skip compilation for non-React files to improve performance. ([@josephsavona](https://github.com/josephsavona) in [#35589](facebook/react#35589)) - Fix exhaustive deps bug with Flow type casting. ([@jorge-cab](https://github.com/jorge-cab) in [#35691](facebook/react#35691)) - Fix `useEffectEvent` checks in component syntax. ([@jbrown215](https://github.com/jbrown215) in [#35041](facebook/react#35041)) - Improved `set-state-in-effect` validation with fewer false negatives. ([@jorge-cab](https://github.com/jorge-cab) in [#35134](facebook/react#35134), [@josephsavona](https://github.com/josephsavona) in [#35147](facebook/react#35147), [@jackpope](https://github.com/jackpope) in [#35214](facebook/react#35214), [@chesnokov-tony](https://github.com/chesnokov-tony) in [#35419](facebook/react#35419), [@jsleitor](https://github.com/jsleitor) in [#36107](facebook/react#36107)) - Improved ref validation for non-mutating functions and event handler props. ([@josephsavona](https://github.com/josephsavona) in [#35893](facebook/react#35893), [@kolvian](https://github.com/kolvian) in [#35062](facebook/react#35062)) - Compiler now reports all errors instead of stopping at the first. ([@josephsavona](https://github.com/josephsavona) in [#35873](https://github.com/facebook/react/pull/35873)–[#35884](https://github.com/facebook/react/pull/35884)) - Improved source locations and error display in compiler diagnostics. ([@nathanmarks](https://github.com/nathanmarks) in [#35348](facebook/react#35348), [@josephsavona](https://github.com/josephsavona) in [#34963](facebook/react#34963)) </details> <details> <summary>fkhadra/react-toastify (react-toastify)</summary> ### [`v11.1.0`](https://github.com/fkhadra/react-toastify/releases/tag/v11.1.0) [Compare Source](fkhadra/react-toastify@v11.0.5...v11.1.0) ### Release Notes #### Features - **CSP nonce support.** `<ToastContainer nonce={...}>` applies the nonce to the injected `<style>` tag. Closes [#1209](fkhadra/react-toastify#1209). #### Fixes - `onChange` fires `status: 'removed'` synchronously on `toast.dismiss()` instead of after the exit animation — observers (incl. `useNotificationCenter`) now see correctly ordered events. Also guards against double-`onClose`. Closes [#1275](fkhadra/react-toastify#1275). - Touch drag no longer re-pauses the toast on release — the old check compared a PointerEvent against `'touchend'`, which never matched. Closes [#1217](fkhadra/react-toastify#1217). - Vertical drag now visually moves the toast (`--y` gets a unit). Thanks [@janpaepke](https://github.com/janpaepke), [#1277](fkhadra/react-toastify#1277). - Stacked scale is clamped at 0.5, preventing zero/negative scale in deep stacks. Closes [#1171](fkhadra/react-toastify#1171), [#1174](fkhadra/react-toastify#1174). - Stacked container respects mobile `100vw` again. Closes [#1234](fkhadra/react-toastify#1234). #### Accessibility - `role="progressbar"` now includes `aria-valuenow`, `aria-valuemin`, `aria-valuemax`. Thanks [@singhankit001](https://github.com/singhankit001), [#1283](fkhadra/react-toastify#1283). Closes [#1259](fkhadra/react-toastify#1259). #### Internal - Migrated to a pnpm workspace (`pnpm link .` no longer required for contributors). Publish layout unchanged — addon still ships inside the main package. - CSS now injected at mount via `useStyleSheet` (prerequisite for `nonce`). - Dep bumps: TypeScript 6, Vite 8, Cypress 15, React 19.2, plus the rest. - CI: `upload-artifact` v3 → v4. Thanks to [@janpaepke](https://github.com/janpaepke), [@singhankit001](https://github.com/singhankit001), and reporters of the fixed issues. </details> <details> <summary>typescript-eslint/typescript-eslint (typescript-eslint)</summary> ### [`v8.59.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-eslint/CHANGELOG.md#8590-2026-04-20) [Compare Source](typescript-eslint/typescript-eslint@v8.58.2...v8.59.0) This was a version bump only for typescript-eslint to align it with other projects, there were no code changes. See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.59.0) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>sapphi-red/vite-plugin-static-copy (vite-plugin-static-copy)</summary> ### [`v4.1.0`](https://github.com/sapphi-red/vite-plugin-static-copy/blob/HEAD/CHANGELOG.md#410) [Compare Source](https://github.com/sapphi-red/vite-plugin-static-copy/compare/vite-plugin-static-copy@4.0.1...vite-plugin-static-copy@4.1.0) ##### Minor Changes - [#251](sapphi-red/vite-plugin-static-copy#251) [`7672842`](sapphi-red/vite-plugin-static-copy@7672842) Thanks [@sapphi-red](https://github.com/sapphi-red)! - Add `name` property to the `rename` object form and allow rename functions to return a `RenameObject`. The `name` property replaces the file's basename (filename + extension), and can be combined with `stripBase` to both flatten directory structure and rename the file in one step. Rename functions can now return `{ name, stripBase }` objects instead of only strings, making it easier to declaratively control output paths from dynamic rename logic. ```js // node_modules/lib/dist/index.js → vendor/lib.js { src: 'node_modules/lib/dist/index.js', dest: 'vendor', rename: { name: 'lib.js', stripBase: true } } // src/pages/events/test.html → dist/events/index.html { src: 'src/pages/**/*.html', dest: 'dist/', rename: { stripBase: 2, name: 'index.html' } } ``` </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!480 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>

meta-cla Bot added the CLA Signed label Nov 13, 2025

jorge-cab force-pushed the pr35134 branch from 9228bdb to 81510eb Compare November 13, 2025 23:51

jorge-cab force-pushed the pr35134 branch from 81510eb to cd1d0dc Compare November 14, 2025 00:03

jorge-cab mentioned this pull request Nov 14, 2025

[Compiler] Avoid capturing global setStates for no-derived-computations lint #35135

Merged

josephsavona approved these changes Nov 14, 2025

View reviewed changes

josephsavona reviewed Nov 14, 2025

View reviewed changes

jorge-cab merged commit de97ef9 into main Nov 14, 2025
18 of 27 checks passed

nextjs-bot mentioned this pull request Nov 14, 2025

Upgrade React from 52684925-20251110 to 257b033f-20251113 vercel/next.js#86137

Closed

nextjs-bot mentioned this pull request Nov 15, 2025

Upgrade React from 93fc5740-20251113 to fb2177c1-20251114 vercel/next.js#86155

Merged

This was referenced Apr 18, 2026

[Compiler Bug]: react-hooks/set-state-in-effect false positive on async function #34905

Open

Bug: react-hooks/set-state-in-effect overly strict? #34743

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Compiler] Don't count a setState in the dependency array of the effect it is called on as a usage#35134

[Compiler] Don't count a setState in the dependency array of the effect it is called on as a usage#35134
jorge-cab merged 1 commit intomainfrom
pr35134

jorge-cab commented Nov 13, 2025 •

edited

Loading

Uh oh!

josephsavona Nov 14, 2025

Uh oh!

jorge-cab Nov 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jorge-cab commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josephsavona Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

jorge-cab Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jorge-cab commented Nov 13, 2025 •

edited

Loading