-
Notifications
You must be signed in to change notification settings - Fork 51k
Fix FragmentInstance listener leak: normalize boolean vs object capture options per DOM spec #36047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jackpope
merged 7 commits into
facebook:main
from
Dhakshin2007:fix/fragment-ref-capture-option-normalization
Apr 22, 2026
+165
−1
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ce7699a
Add parameters to options string iFix FragmentInstance listener key m…
Dhakshin2007 c380e05
Add tests for removing capture listAdd tests for capture option norma…
Dhakshin2007 fcefce9
fix: key listener identity on capture only, drop passive/once from ke…
Dhakshin2007 47cd78d
test: add passive option mismatch test for FragmentRef addEventListener
Dhakshin2007 db9b321
fix: correct passive test - per DOM spec passive is not part of liste…
Dhakshin2007 1116d4a
test: clarify passive handler comments and add cross-passive removal …
Dhakshin2007 da1e8bb
test: add jest.spyOn assertion to confirm single listener registration
Dhakshin2007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test should make it clear which handler is fired: The first or second one? By spec, the second handler shouldn't have been appended:
-- https://dom.spec.whatwg.org/#concept-event-listener:~:text=The%20event%20listener%20is%20appended%20to%20target%E2%80%99s%20event%20listener%20list%20and%20is%20not%20appended%20if%20it%20has%20the%20same%20type%2C%20callback%2C%20and%20capture.
It also looks like there's some asymmetry with removing. For adding we just look at
capture. But removing apparently looks at all the options:-- https://dom.spec.whatwg.org/#concept-event-listener:~:text=Removes%20the%20event%20listener%20in%20target%E2%80%99s%20event%20listener%20list%20with%20the%20same%20type%2C%20callback%2C%20and%20options.
Can you do some testing how popular browsers behave?