Conversation
|
Comparing: 0c44b96...90fd0c0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Member
|
I need some tests to understand what wasn't covered before and what's covered now |
hoxyq
force-pushed
the
infinite-render-loop/warn-fix
branch
from
8d8ef64 to
d22ee6a
Compare
Contributor
Author
@rickhanlonii, I've added a test that reproduces the previously failing scenario. Please see the updated summary as well. |
hoxyq
force-pushed
the
infinite-render-loop/warn-fix
branch
2 times, most recently
from
2b9b20a to
4ec0db7
Compare
…initeRenderLoopDetection
hoxyq
force-pushed
the
infinite-render-loop/warn-fix
branch
from
4ec0db7 to
90fd0c0
Compare
jackpope
reviewed
Apr 10, 2026
| }); | ||
|
|
||
| it('warns instead of throwing when infinite Suspense ping loop is detected via enableInfiniteRenderLoopDetection during commit phase', async () => { | ||
| if (!__DEV__ || gate(flags => !flags.enableInfiniteRenderLoopDetection)) { |
Contributor
Author
There was a problem hiding this comment.
Not at the current state. If we use @gate pragma, then the test has to fail when the gating conditions are not met. It fails, but because of the infinite loop, which is prevented by Jest, and such failure is not considered as "good" failure.
jackpope
approved these changes
Apr 13, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
…initeRenderLoopDetection (#36195) My change in #35999 did not cover all possible scenarios for emitting a warning, instead of throwing. The instrumentation not only enables the identification for the infinite loop via execution context checks, but also adds the check to more lifecycle methods, like `markRootPinged` and `markRootUpdated`. See the newly added test to understand a potential scenario. Before the fix, the error would be thrown: <img width="1192" height="424" alt="Screenshot 2026-04-08 at 17 21 51" src="https://github.com/user-attachments/assets/ba8ea379-0271-4938-ae45-e37ee75e1963" /> With the current changes, the warning is logged with `console.error`. DiffTrain build for [fef12a0](fef12a0)
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
…initeRenderLoopDetection (#36195) My change in #35999 did not cover all possible scenarios for emitting a warning, instead of throwing. The instrumentation not only enables the identification for the infinite loop via execution context checks, but also adds the check to more lifecycle methods, like `markRootPinged` and `markRootUpdated`. See the newly added test to understand a potential scenario. Before the fix, the error would be thrown: <img width="1192" height="424" alt="Screenshot 2026-04-08 at 17 21 51" src="https://github.com/user-attachments/assets/ba8ea379-0271-4938-ae45-e37ee75e1963" /> With the current changes, the warning is logged with `console.error`. DiffTrain build for [fef12a0](fef12a0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My change in #35999 did not cover all possible scenarios for emitting a warning, instead of throwing.
The instrumentation not only enables the identification for the infinite loop via execution context checks, but also adds the check to more lifecycle methods, like
markRootPingedandmarkRootUpdated.See the newly added test to understand a potential scenario. Before the fix, the error would be thrown:
With the current changes, the warning is logged with
console.error.