Skip to content

Fix minor typo error#9

Merged
zpao merged 1 commit intofacebook:masterfrom
christianroman:master
May 29, 2013
Merged

Fix minor typo error#9
zpao merged 1 commit intofacebook:masterfrom
christianroman:master

Conversation

@christianroman
Copy link
Copy Markdown
Contributor

No description provided.

@zpao
Copy link
Copy Markdown
Member

zpao commented May 29, 2013

Nice catch! This is what happens when we're all on little sleep. For now we need all contributors to have a CLA on file. I didn't find one for you so I just need to make sure that you've done that at https://developers.facebook.com/opensource/cla. Let me know when it's done and I'll merge this in. Thanks a lot!

@christianroman
Copy link
Copy Markdown
Contributor Author

It's done, I signed the CLA

@zpao
Copy link
Copy Markdown
Member

zpao commented May 29, 2013

Awesome. Thanks again!

zpao added a commit that referenced this pull request May 29, 2013
@zpao zpao merged commit fd321cf into facebook:master May 29, 2013
zpao added a commit that referenced this pull request Oct 3, 2013
zpao pushed a commit that referenced this pull request Oct 8, 2013
zpao pushed a commit that referenced this pull request Oct 8, 2013
zpao added a commit that referenced this pull request Oct 8, 2013
cristiancavalli referenced this pull request in cristiancavalli/react Jul 22, 2015
…imationFrame so that transitionend event is triggered more consistently
unstubbable pushed a commit to unstubbable/react that referenced this pull request Jan 23, 2026
switz added a commit to switz/react that referenced this pull request Mar 25, 2026
…ok#9)

v2 measured wall-clock time with simulated I/O, which hid the CPU cost.
Throughput is limited by CPU, not I/O. Under concurrent load on a single
Node.js thread:

  c=25, 226 products:
  - Fizz only:      526 req/s, p99=49ms,  heap +72MB
  - Full pipeline:  102 req/s, p99=342ms, heap +282MB
  - Drop: 5.2x throughput, 7.0x p99, +210MB heap

The overhead worsens under load (4x at c=1 → 5.9x at c=50) because
the 349KB wire format buffer per request creates GC pressure that
compounds with concurrency.

This directly explains the 400→40 rps drop in real deployments:
React-level 3-6x × framework overhead 1.5-2x ≈ 10x.

Recommendation: proceed with fused renderer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants