🔨 Fix commit_in_place passed via env variable in translate.yml workflow#15151
Merged
YuriiMotov merged 1 commit intomasterfrom Mar 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in
Click < 8.3.0that the value of ENV variable is being interpreted incorrectly for bool flags ("false"becomesTrue).This leads to our
translate.ymlworkflow to fail withCan't commit directly to master(see https://github.com/fastapi/fastapi/actions/runs/23245751473/job/67573656641)This bug has been fixed in latest versions of Click, but we can't upgrade due to another bug introduced in
Click 8.2.2and still present in latest version (see #15057 and mkdocs/mkdocs#4032).I suggest we use a workaround until it has been solved - pass empty value instead of
"false".I checked locally - it works.
Alternatively we can pass
commit_in_placein command line instead of using ENV variable