Crash

[mcollina]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure it has not already been reported

Fastify version

not fastify

Plugin version

No response

Node.js version

14

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

20.04

Description

internal/modules/cjs/loader.js:905
  throw err;
  ^

Error: Cannot find module 'pre-commit'
Require stack:
- /home/matteo/repositories/on-exit-or-gc/[eval]
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.resolve (internal/modules/cjs/helpers.js:98:19)
    at [eval]:1:21
    at Script.runInThisContext (vm.js:134:12)
    at Object.runInThisContext (vm.js:311:38)
    at internal/process/execution.js:77:19
    at [eval]-wrapper:6:22
    at evalScript (internal/process/execution.js:76:60)
    at internal/main/eval_string.js:23:3 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/matteo/repositories/on-exit-or-gc/[eval]' ]
}
internal/modules/cjs/loader.js:905
  throw err;
  ^

Error: Cannot find module 'pre-commit'
Require stack:
- /home/matteo/repositories/on-exit-or-gc/[eval]
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.resolve (internal/modules/cjs/helpers.js:98:19)
    at [eval]:1:21
    at Script.runInThisContext (vm.js:134:12)
    at Object.runInThisContext (vm.js:311:38)
    at internal/process/execution.js:77:19
    at [eval]-wrapper:6:22
    at evalScript (internal/process/execution.js:76:60)
    at internal/main/eval_string.js:23:3 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/matteo/repositories/on-exit-or-gc/[eval]' ]
}

Steps to Reproduce

Install

Expected Behavior

No response

[jsumners]

What is the package.json?

[MSE99]

I'm having the same issue as well (on Ubuntu linux 20.04), here's my package.json file:

{
  "name": "app",
  "version": "1.0.0",
  "description": "",
  "main": "./server.js",
  "scripts": {
    "lint": "eslint .",
    "lint:fix": "eslint . --fix",
    "test": "tap ./tests/*.test.js"
  },
  "pre-commit": [
    "lint",
    "test"
  ],
  "repository": {
    "type": "git",
    "url": "git+https://github.com/MSE99/repo.git"
  },
  "author": "Mohamed Edrah",
  "license": "GPL-3.0-or-later",
  "bugs": {
    "url": "https://github.com/MSE99/repo/issues"
  },
  "homepage": "https://github.com/MSE99/repo#readme",
  "devDependencies": {
    "eslint": "^7.29.0",
    "eslint-config-standard": "^16.0.3",
    "eslint-plugin-import": "^2.23.4",
    "eslint-plugin-node": "^11.1.0",
    "eslint-plugin-promise": "^5.1.0",
    "migrate-mongo": "^8.2.2",
    "mongodb-memory-server": "^7.1.0",
    "pino-pretty": "^5.0.2",
    "proxyquire": "^2.1.3",
    "tap": "^15.0.9"
  },
  "dependencies": {
    "@fastify/pre-commit": "^2.0.1",
    "fastify": "^3.18.1",
    "fastify-autoload": "^3.8.0",
    "fastify-env": "^2.1.1",
    "fastify-plugin": "^3.0.0",
    "fluent-json-schema": "^3.0.0",
    "mongoose": "^5.13.2"
  }
}

[jsumners]

I'm not clear what the error message above is saying since it shouldn't be looking for pre-commit module. It should be looking for @fastify/pre-commit. Is this related to #27?

[MSE99]

@jsumners Do you think line 49 in hook script might cause this problem ?.

Edit: just did a basic manual test, replacing require.resolve('pre-commit') with require.resolve('@fastify/pre-commit') solved the issue for me.

[jsumners]

Good find. A pull request would be great.