Merged
Conversation
mykhalchuk-m
requested changes
Oct 3, 2023
mykhalchuk-m
left a comment
mykhalchuk-m
left a comment
There was a problem hiding this comment.
Also, please add a ticket into backlog to cover the code with unit tests
|
|
||
| if (!notFoundList.isEmpty()) { | ||
| notFoundList.forEach(id -> emitter.emitError( | ||
| new InvalidEntry<>(1, String.format("Not found in MDM. UUID: %s", id), input))); |
There was a problem hiding this comment.
The error code needs to be documented appropriately so the message doesn't need to be present in response. The message filed just needs to contain the UUID that was not found.
Author
There was a problem hiding this comment.
now message contains only UUID that was not found
| lookupData.add(processProperty(input, field)); | ||
| } | ||
| } else { | ||
| LOG.warn("Unrecognized field type"); |
There was a problem hiding this comment.
This log is useless as we expect only particular field types to be processed here.
mykhalchuk-m
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.