fix(MakeMaker): stage EXE_FILES into blib/script/ for make test#537
Merged
fix(MakeMaker): stage EXE_FILES into blib/script/ for make test#537
Conversation
Standard ExtUtils::MakeMaker stages executable scripts listed in
EXE_FILES into blib/script/ during `make`, mirroring how .pm files
are staged into blib/lib/. Test suites rely on this: for example,
Pod::Markdown's t/pod2markdown.t invokes blib/script/pod2markdown
directly.
PerlOnJava's MakeMaker shim only copied EXE_FILES to the final
install bin directory during `make install`, leaving blib/script/
empty and causing 6 test failures in `jcpan -t Pod::Markdown`:
Error: Unable to read file blib/script/pod2markdown
Add a blib_scripts target (invoked from all::) that copies each
EXE_FILES entry to blib/script/<basename>. After the fix, Pod::Markdown
passes all 18 test files / 356 tests via `jcpan -t`.
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes test failures in
jcpan -t Pod::Markdownwhere 6 tests int/pod2markdown.tfailed with:Root cause
Standard ExtUtils::MakeMaker stages executable scripts listed in
EXE_FILESintoblib/script/duringmake, the same way.pmfiles are staged intoblib/lib/. Test suites rely on this layout — Pod::Markdown'st/pod2markdown.tinvokesblib/script/pod2markdowndirectly via$^X.PerlOnJava's MakeMaker shim only copied
EXE_FILESto the final install bin directory duringmake install, soblib/script/was never populated and script-based tests failed.Fix
Add a
blib_scriptstarget (invoked fromall::) that copies eachEXE_FILESentry toblib/script/<basename>, mirroring the existingpure_alllogic for modules.Test plan
jcpan -t Pod::Markdown— all 18 test files / 356 tests pass (previously 6 failures)make— all PerlOnJava unit tests pass, no regressionsblib/script/pod2markdownis created aftermakein the module build dirGenerated with Devin