removed bootstrap classes from winter draft generator#89
removed bootstrap classes from winter draft generator#89pmckernin merged 1 commit intowinter-2020from
Conversation
| <% elsif attribute.field_type.to_s.gsub(/_.*/, "").to_sym == :datetime -%> | ||
| <input type="datetime-local" id="<%= attribute.column_name %>_box" name="query_<%= attribute.column_name %>" | ||
| class="form-control" value="<%%= @<%= singular_table_name %>.<%= attribute.column_name %> %>"> | ||
| value="<%%= @<%= singular_table_name %>.<%= attribute.column_name %> %>"> |
There was a problem hiding this comment.
An extraneous new line appears to have been inserted here.
|
@pmckernin Is it necessary to remove all the classes from each View, even though students will only ever get the Unless, of course, we talk about more flags this quarter. |
pmckernin
left a comment
pmckernin
left a comment
There was a problem hiding this comment.
@jelaniwoods That is a good question. If we do decide to start going over partials it would be good to have it match the rest of the generators. I think that we should ask @raghubetina what he thinks about removing the classes from all the partial forms as well as the show and index pages.
| for="<%= attribute.column_name %>_box"><%= attribute.column_name.humanize %></label> | ||
| <label for="<%= attribute.column_name %>_box"> | ||
| <%= attribute.column_name.humanize %> | ||
| </label> |
There was a problem hiding this comment.
@raghubetina The new line was put here so the opening and closing label tags would match how they are being used the same as in lines 101-103.
|
I spoke with @raghubetina about removing bootstrap from all of the draft:resource generators. Also, the extra line is to make sure our |
pmckernin
force-pushed
the
pm-remove-bootstrap-from-winter
branch
from
7f596a3 to
aff224a
Compare
3 participants
This pull requests address #85. I have removed the bootstrap classes from the winter-2020 branch.