Skip to content

[Gallery] Exclude semantics for logo and change to hint for products on Shrine#292

Merged
perclasson merged 2 commits intoflutter:masterfrom
perclasson:exclude_logo_and_change_to_hint_for_products
Jan 29, 2020
Merged

[Gallery] Exclude semantics for logo and change to hint for products on Shrine#292
perclasson merged 2 commits intoflutter:masterfrom
perclasson:exclude_logo_and_change_to_hint_for_products

Conversation

@perclasson
Copy link
Copy Markdown
Contributor

@perclasson perclasson commented Jan 29, 2020

  • We do not need to read out the Shrine logo for screen readers (from the a11y talk on Flutter Interact: https://youtu.be/bWbBgbmAdQs?t=849).
  • On VoiceOver we do not read onTapHint, so I changed it to hint.

Closes material-components/material-components-flutter-gallery#483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shrine - set hint text to products to indicate what happens when you tap them (1)

2 participants