Fix - text on MaterialButton not changing#324
Merged
redbrogdon merged 2 commits intoflutter:masterfrom Feb 21, 2020
Merged
Conversation
text on MaterialButton was not changing from 'Write Essay' to 'Delete Essay' and vice versa because setState was never called
Contributor
|
Thanks for submitting a pull request, @yuhamadan! It looks like our automated tests are failing due to a formatting issue with the code you've added. Try running |
did not think about formatting as I was editing the file directly on Github
Contributor
Author
|
Thanks for the info @redbrogdon |
redbrogdon
requested review from
redbrogdon
and removed request for
johnpryan
redbrogdon
approved these changes
Feb 21, 2020
Contributor
redbrogdon
left a comment
redbrogdon
left a comment
There was a problem hiding this comment.
This is ready to land. Thanks, @yuhamadan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text on MaterialButton was not changing from 'Write Essay' to 'Delete Essay' and vice versa because setState was never called