Searchbar style fix#326
Searchbar style fix#326redbrogdon merged 8 commits intoflutter:masterfrom jurgenizer:searchbar-style-fix
Conversation
redbrogdon
left a comment
redbrogdon
left a comment
There was a problem hiding this comment.
@jurgenizer, thanks for submitting a PR! I've pinged a couple engineers who work with our Cupertino package to get more domain expertise for the review.
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
| CLANG_ENABLE_MODULES = YES; | ||
| CURRENT_PROJECT_VERSION = 8; | ||
| DEVELOPMENT_TEAM = ""; |
There was a problem hiding this comment.
These lines can just be taken out.
|
Ah, it looks like our automated tests have flagged the formatting in |
| child: CupertinoTextField( | ||
| controller: controller, | ||
| focusNode: focusNode, | ||
| decoration: BoxDecoration(), |
There was a problem hiding this comment.
According to the documentation decoration is nullable. So:
| decoration: BoxDecoration(), | |
| decoration: null, |
There was a problem hiding this comment.
Thanks! I updated it now
|
Awesome. Sounds like we've got the right change. @jurgenizer, I think there are still some changes in the project file that need to be taken out. Other than that, though, this looks ready to land! |
redbrogdon
left a comment
redbrogdon
left a comment
There was a problem hiding this comment.
Thanks for submitting! I'm going to land this now.
3 participants
A styling fix to remove the white area behind the CupertinoTextField.
The fix makes search bar look like default iOS search bar.
before:
after:
