fix: 'hexoid is not a function' when using webpack#1817
Merged
titanism merged 1 commit intoforwardemail:masterfrom Oct 18, 2024
Merged
fix: 'hexoid is not a function' when using webpack#1817titanism merged 1 commit intoforwardemail:masterfrom
titanism merged 1 commit intoforwardemail:masterfrom
Conversation
Collaborator
|
v10.1.1 released to npm, thanks for your contributions https://github.com/ladjs/superagent/releases/tag/v10.1.1 maintenance is sponsored by https://forwardemail.net and many thanks to contributors including yourself @icholy 🙏 |
Contributor
Author
|
Thanks for the quick turnaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1786 which was (mistakenly?) marked as fixed. It's a long-standing issue when using superagent with webpack.
Root Cause: The transitive hexoid dependency exports were invalid and broke webpack.
Related Links:
hexoidin formidable@2.0.1 node-formidable/formidable#871Checklist
Master isn't passing for me locally.