feat: add support boolean in CSPListDirectiveValue#16
Merged
frux merged 2 commits intofrux:masterfrom Oct 8, 2025
Merged
Conversation
frux
reviewed
Sep 25, 2025
Owner
frux
left a comment
There was a problem hiding this comment.
Привет! Спасибо за PR. Подскажи, для какого кейса нужна поддержка Boolean?
Contributor
Author
|
Жесть, вот это тесен мир, привет! :) Только сейчас увидел автора. getCSP({
directives: {
'script-src': [
// выкидывать какую-то часть по флагу
someFlag && SELF,
// ну и просто вырезать пустые значения
'',
INLINE,
],
},
reportUri: 'https://cspreport.com/send'
}); |
Owner
Да, тесен :) Тогда давай строже напишем тип, чтобы туда true не мог попасть. |
Contributor
Author
|
Отличная идея, обновил |
frux
approved these changes
Oct 8, 2025
Owner
|
Спасибо за PR! Выпустил в версии 6.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.