ClickHouse query runner: fixed error message#6764
Merged
justinclift merged 11 commits intogetredash:masterfrom Mar 17, 2024
Merged
ClickHouse query runner: fixed error message#6764justinclift merged 11 commits intogetredash:masterfrom
justinclift merged 11 commits intogetredash:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6764 +/- ##
==========================================
- Coverage 63.43% 63.42% -0.01%
==========================================
Files 163 163
Lines 13200 13203 +3
Branches 1822 1823 +1
==========================================
+ Hits 8373 8374 +1
- Misses 4530 4531 +1
- Partials 297 298 +1
|
konnectr
approved these changes
Feb 27, 2024
Member
Author
|
@getredash/maintainers could you merge it please? Now we don't see any messages on errors, it's difficult to debug errors in SQL. |
Member
|
Your branch has some conflict. I updated your branch, if CI have pass, i will merge it. Don't worry. |
Member
|
Looks like it's passing enough. Lets merge it. 😄 |
Member
Author
|
Thanks! |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
* Snapshot: 23.11.0-dev * Snapshot: 23.12.0-dev * Snapshot: 24.01.0-dev * Snapshot: 24.02.0-dev * clickhouse: check for `exception` field in response --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Vladislav Denisov <denisov@sports.ru> Co-authored-by: Guido Petri <18634426+guidopetri@users.noreply.github.com> Co-authored-by: Peter Lee <yankeeguyu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Since ~ 23.10 ClickHouse returns 200 status code for all types of requests, but adds
exceptionin response. This PR adds conditions to check for this key.How is this tested?
Related Tickets & Documents
#6756
Mobile & Desktop Screenshots/Recordings (if there are UI changes)