Query schedule may not always contain an "until" key

[robinedwards]

What type of PR is this?

• Refactor
• Feature
• Bug Fix
• New Query Runner (Data Source)
• New Alert Destination
• Other

Description

Noticed this error occurring from redash in our Sentry:

How is this tested?

• Unit tests (pytest, jest)
• E2E Tests (Cypress)
• Manually
• N/A

Sentry error stopped occurring

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.43%. Comparing base (d554136) to head (46aacf8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6771   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files         163      163           
  Lines       13200    13200           
  Branches     1822     1822           
=======================================
  Hits         8373     8373           
  Misses       4530     4530           
  Partials      297      297           

Files	Coverage Δ
redash/models/__init__.py	91.95% <ø> (ø)

[eradman]

I can't figure out how schedule->until can end up missing, unless the queries table was modified manually. Are there any other keys missing? Try running this:

SELECT id,array_agg(keys) AS key
FROM queries, jsonb_object_keys(schedule::jsonb) keys
GROUP BY id ORDER BY id;

[robinedwards]

I've not modified it manually, there was a new migration added:

https://github.com/getredash/redash/blob/master/migrations/versions/640888ce445d_.py

Which touches the column.

Running your query:

redash=> SELECT id,array_agg(keys) AS key
FROM queries, jsonb_object_keys(schedule::jsonb) keys
GROUP BY id ORDER BY id;
ERROR:  cannot call jsonb_object_keys on a scalar

Looking a bit closer I have several rows where the schedule is null:

redash=> select count(*) from queries where schedule is null;
 count 
-------
   255
(1 row)

Then picking out a few examples where until is null:

redash=> select schedule from queries where schedule is not null limit 10;
                                   schedule                                    
-------------------------------------------------------------------------------
 {"time": "08:00", "until": null, "interval": 604800, "day_of_week": "Monday"}
 {"time": "23:15", "until": null, "interval": 86400, "day_of_week": null}
 {"time": "08:00", "until": null, "interval": 604800, "day_of_week": "Monday"}
 {"time": "00:15", "until": null, "interval": 86400, "day_of_week": null}
 null
 {"time": "09:00", "until": null, "interval": 604800, "day_of_week": "Monday"}
 {"time": "01:15", "until": null, "interval": 604800, "day_of_week": "Sunday"}
 {"time": null, "until": null, "interval": 3600, "day_of_week": null}
 {"time": null, "until": null, "interval": 3600, "day_of_week": null}
 {"disabled": true}
(10 rows)```

[robinedwards]

@justinclift would it be possible to get a review

[justinclift]

@guidopetri Do you have time to look at this? It seems super simple. 😄

[eradman]

This record is wrong

 {"disabled": true}

But I can't figure out how this value was set. Seems like it must have been a failed migration. Approving since we're not making progress. After this query is updated I expect the schedule to be formatted with standard fields.

[justinclift]

Approving since we're not making progress.

Thanks. Just merged it. 😄