Autoformat hyperlinks in Slack alerts#6845
Merged
justinclift merged 2 commits intogetredash:masterfrom Apr 3, 2024
Merged
Conversation
Format the Slack message using the "mrkdwn" type, which will make hyperlinks clickable. New test for Slack destination.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6845 +/- ##
==========================================
+ Coverage 63.43% 63.50% +0.06%
==========================================
Files 163 163
Lines 13206 13206
Branches 1824 1824
==========================================
+ Hits 8377 8386 +9
+ Misses 4531 4518 -13
- Partials 298 302 +4
|
justinclift
approved these changes
Apr 3, 2024
Member
justinclift
left a comment
justinclift
left a comment
There was a problem hiding this comment.
Cool, looks good to me. 😄
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Format the Slack message using the "mrkdwn" type, which will make hyperlinks clickable. New test for Slack destination. Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Format the Slack message using the "mrkdwn" type, which will make hyperlinks clickable.
How is this tested?
Created alert destination using webhook url, verified in Slack channel.
Related Tickets & Documents
#6821
Screenshot