Skip to content

fix for coverage#6872

Merged
justinclift merged 2 commits intogetredash:masterfrom
AndrewChubatiuk:coverage-fix
Apr 11, 2024
Merged

fix for coverage#6872
justinclift merged 2 commits intogetredash:masterfrom
AndrewChubatiuk:coverage-fix

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.82%. Comparing base (af0773c) to head (dc97ee0).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6872   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files         161      161           
  Lines       13060    13060           
  Branches     1803     1803           
=======================================
  Hits         8335     8335           
  Misses       4425     4425           
  Partials      300      300           

Copy link
Copy Markdown
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 😄

@justinclift justinclift enabled auto-merge (squash) April 11, 2024 05:08
@justinclift justinclift merged commit 95ecb8e into getredash:master Apr 11, 2024
@justinclift
Copy link
Copy Markdown
Member

Thanks for getting this done @AndrewChubatiuk. 😄

@AndrewChubatiuk AndrewChubatiuk deleted the coverage-fix branch May 9, 2024 18:28
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
Co-authored-by: Andrii Chubatiuk <wachy@Andriis-MBP-2.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants