Adding ability to fix table columns in place#7019
Conversation
This change involved adding an extra option to the GridSettings editor, adding the "fixed" option to columns, and adding styling for the fixed columns. In order to change the number of fixed columns, which will default to 0, one has to go to Edit visualization -> Grid -> Choose number of columns to fix -> Save.
ezraodio1
force-pushed
the
freeze_columns
branch
from
2c1354b to
a0bad9d
Compare
ezraodio1
force-pushed
the
freeze_columns
branch
from
a0bad9d to
bbdf73a
Compare
|
The frontend e2e Cypress tests that are failing are due to an invisible row that's being added at the top of the table (see attached screenshot). This, for some reason, is due to the following line of code in Renderer.tsx: The error persists with Per Ant Design documentation, "To fix some columns and scroll inside other columns, and you must set scroll.x meanwhile." 
|
|
In order to fix this issue, I changed the table.js, and therefore the Cypress tests that were failing, to not count this invisible row. |
Without this, Cypress was counting the
.ant-table-measure-row, which is an invisible row
at the top of the table created by
scroll = {{x : 'max-content'}} in Renderer.tsx.
This was causing the query/filters_spec.js and
dashboard/filters_spec.js Cypress tests to fail.
ezraodio1
force-pushed
the
freeze_columns
branch
from
62af527 to
45fe4a7
Compare
eradman
left a comment
eradman
left a comment
There was a problem hiding this comment.
Very nice. Tested manually, no issues found
|
@ezraodio1 @eradman We've received a credible report that this PR broke vertical scrolling behaviour when there's greater than some number (25?) results. Any ideas? I'm not yet super clueful with the front end pieces of Redash, so can't be super constructive with this bit just yet. |
This reverts commit ebb0e2c. Restyled by prettier
This reverts commit ebb0e2c. This feature disabled vertical scroll in query results: getredash#7127
This change involved adding an extra option to the GridSettings editor, adding the "fixed" option to columns, and adding styling for the fixed columns. In order to change the number of fixed columns, which will default to 0, one has to go to Edit visualization -> Grid -> Choose number of columns to fix -> Save.
4 participants
What type of PR is this?
Description
This change involved adding an extra option to the GridSettings editor, adding the "fixed" option to columns, and adding styling for the fixed columns. In order to change the number of fixed columns, which will default to 0, one has to go to Edit visualization -> Grid -> Choose number of columns to fix -> Save.
How is this tested?
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
My.Movie.2.mp4