Add min/max/first selector for alerts#7076
Merged
eradman merged 3 commits intogetredash:masterfrom Aug 1, 2024
Merged
Conversation
Collaborator
|
Very nice feature! We should also add a new variable called See redash/redash/models/__init__.py Lines 992 to 1000 in a69f7fb |
Contributor
Author
Good call. Just added the selector to the template. |
eradman
reviewed
Jul 31, 2024
153a560 to
ee5e9b5
Compare
eradman
reviewed
Jul 31, 2024
ee5e9b5 to
1439797
Compare
1439797 to
cf69691
Compare
eradman
approved these changes
Aug 1, 2024
This was referenced Aug 1, 2024
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This feature allows the user to create an alert that checks the minimum, maximum, or first value of a column when evaluating.
Currently, alerts will only check the first value of a column when evaluating.
This change makes alerts more useful and allows users to set up new kinds of conditions to test for.
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)