Skip to content

Add data type to athena query runner#7112

Merged
justinclift merged 7 commits intogetredash:masterfrom
zachliu:add-data_type-to-athena-query-runner
Aug 7, 2024
Merged

Add data type to athena query runner#7112
justinclift merged 7 commits intogetredash:masterfrom
zachliu:add-data_type-to-athena-query-runner

Conversation

@zachliu
Copy link
Copy Markdown
Contributor

@zachliu zachliu commented Aug 7, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Both Athena's information_schema & boto3 Glue's get_tables method support data_type. We should make good use of it! 💪

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

athena

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@justinclift
Copy link
Copy Markdown
Member

Seems pretty straight forward, lets get it merged. 😄

@justinclift justinclift enabled auto-merge (squash) August 7, 2024 03:08
@justinclift justinclift merged commit 285c2b6 into getredash:master Aug 7, 2024
@zachliu zachliu deleted the add-data_type-to-athena-query-runner branch August 7, 2024 13:44
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants