Upgrade plotly.js to version 2 to fix the UI crashing issue#7359
Merged
eradman merged 2 commits intogetredash:masterfrom Mar 5, 2025
Merged
Upgrade plotly.js to version 2 to fix the UI crashing issue#7359eradman merged 2 commits intogetredash:masterfrom
eradman merged 2 commits intogetredash:masterfrom
Conversation
yoshiokatsuneo
changed the title
yoshiokatsuneo
force-pushed
the
feat/upgrade_plotlyjs_version2
branch
from
0932017 to
98bf2d9
Compare
yoshiokatsuneo
force-pushed
the
feat/upgrade_plotlyjs_version2
branch
3 times, most recently
from
6d05d35 to
ab0098d
Compare
This was referenced Mar 4, 2025
eradman
approved these changes
Mar 5, 2025
Collaborator
eradman
left a comment
eradman
left a comment
There was a problem hiding this comment.
Tested manually with a various kinds of charts. Merging to test this more thoroughly
eradman
force-pushed
the
feat/upgrade_plotlyjs_version2
branch
from
3f97783 to
28553a7
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Redash with plotly.js version 1 have a UI crashing issue #7357 .
Upgrading to Plotly.js version 2 solve the issue.
I could not upgraded to plotly.js version 3 because it uses JavaScript optional chaining ( ?. ) and webpack4 does not support it.
How is this tested?
I confirmed that this PR solved the UI crashing issue #7357 .
Other than that, the UI is same as before.