Skip to content

Make details visualization configurable#7535

Merged
eradman merged 3 commits intogetredash:masterfrom
kfrydel:configurable-details-master
Oct 6, 2025
Merged

Make details visualization configurable#7535
eradman merged 3 commits intogetredash:masterfrom
kfrydel:configurable-details-master

Conversation

@kfrydel
Copy link
Copy Markdown
Contributor

@kfrydel kfrydel commented Sep 18, 2025

What type of PR is this?

  • Feature

Description

This commit makes the Details visualization configurable, especially:

  • adds the possibility to select visible columns and reorder them
  • adds formatting options as in Table visualization

The implementation was created with usage of AI and is based on Table visualization implementation. Common parts of the code were extracted to shared/columnUtils.ts file.

How is this tested?

  • Unit tests yarn test
  • Manually
  1. Create a new query and execute it
  2. Add visualization
  3. Select Details View as Visualization Type
  4. Change order of columns
  5. Hide some column
  6. Edit Column Title, Description, and Alignment of a column
  7. For Number column change format
  8. For Text column containing HTML click Allow HTML content
  9. For Boolean column change values for true and false
  10. For Date column change format

Related Tickets & Documents

No ticket.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Rendered view:

image

Editor:

image

@eradman
Copy link
Copy Markdown
Collaborator

eradman commented Sep 18, 2025

Very nice feature! My first comment is that for the Details visualization Alignment should be Left for all columns by default.

@kfrydel
Copy link
Copy Markdown
Contributor Author

kfrydel commented Sep 18, 2025

You are right, I changed the default when reusing the Table visualization code. I added a commit that fixes this. Thanks!

@eradman
Copy link
Copy Markdown
Collaborator

eradman commented Sep 18, 2025

Can we re-use ../table/Editor/ColumnEditor.tsx? The functionality for Table and Details is almost identical.

@kfrydel kfrydel force-pushed the configurable-details-master branch from de1b2de to ddf5f55 Compare September 19, 2025 11:13
@kfrydel
Copy link
Copy Markdown
Contributor Author

kfrydel commented Sep 19, 2025

Good idea, I extracted the common code to shared directory.
Tests failed on the installation of dependencies. It does not look like the failure is connected to my changes. I suppose it is some intermittent problem. I do not know how to restart them (besides pushing the changes again).

@eradman
Copy link
Copy Markdown
Collaborator

eradman commented Sep 19, 2025

Looks like a transitory failure. I re-triggered the CI tests

@eradman eradman self-requested a review October 2, 2025 17:22
- Added possibility to select visible columns and reordering
- Added formatting options as in Table visualization
@eradman eradman force-pushed the configurable-details-master branch from ddf5f55 to 4010ca6 Compare October 3, 2025 11:21
Copy link
Copy Markdown
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, no issues found!

@eradman eradman merged commit 5b463b0 into getredash:master Oct 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants