BigQuery: Remove "Job ID" metadata on annotaton to avoid cache misses#7541
Merged
yoshiokatsuneo merged 1 commit intogetredash:masterfrom Sep 24, 2025
Conversation
yoshiokatsuneo
force-pushed
the
feat/bigquery_annotation_remove_job_id
branch
from
6c27887 to
96de324
Compare
eradman
approved these changes
Sep 24, 2025
Collaborator
eradman
left a comment
eradman
left a comment
There was a problem hiding this comment.
Not tested, but this change makes sense to me
Contributor
Author
|
@eradman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
On BigQuery datasource, when "Use Query Annotation" is enabled, BigQuery's query result cache does not owkr because the query sent to BigQuery is always different because the annotation have different "Job ID" on the each query.
This PR fixes the BigQuery caching issue by removing "Job ID" from the query annotation so that the query sent to BigQuery is always the same and the BigQuery cache hits.
How is this tested?
I run the same query twice for the BigQuery data source with Use Query Annotation enabled, and I confirmed that the "data scanned" for the second query is zero.