Skip to content

Serialize Trino ROW types as JSON objects with field names#7644

Merged
yoshiokatsuneo merged 5 commits intogetredash:masterfrom
nmosafi:trino-row-type-json-serialization
Feb 28, 2026
Merged

Serialize Trino ROW types as JSON objects with field names#7644
yoshiokatsuneo merged 5 commits intogetredash:masterfrom
nmosafi:trino-row-type-json-serialization

Conversation

@nmosafi
Copy link
Copy Markdown
Contributor

@nmosafi nmosafi commented Feb 25, 2026

Trino ROW (struct) columns were serialized as plain arrays, losing all field name information. This converts NamedRowTuple values to dicts using the field name metadata from the trino library, so ROW fields appear as {"field": value} instead of [value].

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

I tested by querying our local Trino instance before/after this change

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

nmosafi and others added 2 commits February 24, 2026 18:42
Trino ROW (struct) columns were serialized as plain arrays, losing
all field name information. This converts NamedRowTuple values to
dicts using the field name metadata from the trino library, so ROW
fields appear as {"field": value} instead of [value].

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@yoshiokatsuneo yoshiokatsuneo merged commit d78cea5 into getredash:master Feb 28, 2026
16 of 17 checks passed
@yoshiokatsuneo
Copy link
Copy Markdown
Contributor

@nmosafi

I confirmed that it works well. So, I approved and merged the commit.
Thank you for your contribution !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants