Exception when the Django cache integration checks for cache hit

[ddabble]

How do you use Sentry?

Sentry Saas (sentry.io)

Version

2.42.0

Steps to Reproduce

1. Set up Django's cache framework using Redis
2. Call sentry_sdk.init() with:

   integrations=[
       DjangoIntegration(cache_spans=True),
       ...
   ]

3. Cache an instance of NDFrame (we're specifically creating a GeoDataFrame) using cache.set()
4. Retrieve the instance using cache.get()

Expected Result

No exception should be logged using Sentry's internal logger.

Actual Result

This check triggers NDFrame.__bool__(), which raises a ValueError, causing Sentry to log an internal exception.

Fix suggestion

It looks like the previously mentioned check is for whether there was a cache hit or not, and so I'm assuming this bug could be fixed by simply changing the check to if value is not None:, as None is the default value that will be returned by cache.get() on a cache miss.

[linear]

PY-1951

[ddabble]

Update for future readers:

After updating to Sentry 2.43.0, we're still getting the same ValueError as mentioned in the issue description, but now from another line in the same function (where value is a GeoDataFrame and default_value is None):

sentry-python/sentry_sdk/integrations/django/caching.py

Line 86 in b069aa2

if value != default_value:

This time, though, it seems more like a bug with pandas, and so I've opened pandas-dev/pandas#63061.

However, I don't deem it very likely for that to be resolved anytime soon (or ever), since it would probably require a redesign of their class-based API, and so we've fixed it in our application by doing the following monkey patching:

from geopandas import GeoDataFrame

_original_geo_data_frame__eq__ = GeoDataFrame.__eq__
_original_geo_data_frame__ne__ = GeoDataFrame.__ne__


def custom_geo_data_frame__eq__(self: GeoDataFrame, other: object) -> bool:
    if not isinstance(other, GeoDataFrame):
        return False
    return _original_geo_data_frame__eq__(self, other)


def custom_geo_data_frame__ne__(self: GeoDataFrame, other: object) -> bool:
    if not isinstance(other, GeoDataFrame):
        return True
    return _original_geo_data_frame__ne__(self, other)


GeoDataFrame.__eq__ = custom_geo_data_frame__eq__
GeoDataFrame.__ne__ = custom_geo_data_frame__ne__