Skip to content

feat(metrics): Shift flushing by up to a rollup window #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitsuhiko merged 2 commits into from
Sep 28, 2023
Merged

feat(metrics): Shift flushing by up to a rollup window #2396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f272951
feat(metrics): Shift flushing by up to a rollup window
mitsuhiko Sep 28, 2023
ac5dd68
fix: incorrect const
mitsuhiko Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sentry_sdk/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import io
import re
import threading
import random
import time
import zlib
from functools import wraps, partial
Expand Down Expand Up @@ -303,6 +304,14 @@ def __init__(
self._flush_event = Event()
self._force_flush = False

# The aggregator shifts it's flushing by up to an entire rollup window to
# avoid multiple clients trampling on end of a 10 second window as all the
# buckets are anchored to multiples of ROLLUP seconds. We randomize this
# number once per aggregator boot to achieve some level of offsetting
# across a fleet of deployed SDKs. Relay itself will also apply independent
# jittering.
self._flush_shift = random.random() * self.ROLLUP_IN_SECONDS

self._flusher = None # type: Optional[Thread]
self._flusher_pid = None # type: Optional[int]
self._ensure_thread()
Expand Down Expand Up @@ -339,7 +348,7 @@ def _flushable_buckets(self):
# type: (...) -> (Iterable[Tuple[int, Dict[BucketKey, Metric]]])
with self._lock:
force_flush = self._force_flush
cutoff = time.time() - self.ROLLUP_IN_SECONDS
cutoff = time.time() - self.ROLLUP_IN_SECONDS - self._flush_shift
flushable_buckets = () # type: Iterable[Tuple[int, Dict[BucketKey, Metric]]]
weight_to_remove = 0

Expand Down