Remove universal bdist_wheel option from setup.py#6140
Closed
20bytes wants to merge 1 commit intogetsentry:masterfrom
Closed
Remove universal bdist_wheel option from setup.py#614020bytes wants to merge 1 commit intogetsentry:masterfrom
20bytes wants to merge 1 commit intogetsentry:masterfrom
Conversation
Python 2 support was removed, so the `options={"bdist_wheel": {"universal": "1"}}`
flag is no longer needed. Without it, wheels are tagged `py3-none-any` rather than
`py2.py3-none-any`, so also update the hardcoded filename in the Lambda layer
build script to match.
Fixes getsentry#6121
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sdk-maintainer-bot
Bot
added
missing-maintainer-discussion
|
This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6121.
Since Python 2 support was removed, the
options={"bdist_wheel": {"universal": "1"}}setting insetup.pyis no longer needed. That option was responsible for tagging built wheels aspy2.py3-none-any; without it, wheels are correctly taggedpy3-none-any.The only other place that tag appeared was the hardcoded filename in
scripts/build_aws_lambda_layer.py, so that string is updated to match.If I'm missing any other references to the old tag, or if the direction here doesn't fit the team's plans, no problem at all — happy to adjust.
This PR was drafted with AI assistance. The logic and file changes have been reviewed for correctness.