Skip to content

fix: engine size mismatch#5630

Merged
philipp-classen merged 1 commit intoghostery:masterfrom
seia-soto:fix-engine-bytes
Apr 30, 2026
Merged

fix: engine size mismatch#5630
philipp-classen merged 1 commit intoghostery:masterfrom
seia-soto:fix-engine-bytes

Conversation

@seia-soto
Copy link
Copy Markdown
Member

This is 6 years old bug. Probably other components did allow extra space. Engine version and size of list are both uint16 but engine's assuming they're uint8 in getSerializedSize.

@seia-soto seia-soto self-assigned this Apr 29, 2026
@seia-soto seia-soto requested a review from remusao as a code owner April 29, 2026 23:02
@seia-soto seia-soto added the PR: Bug Fix 🐛 Increment patch version when merged label Apr 29, 2026
@seia-soto seia-soto requested a review from chrmod April 29, 2026 23:09
@philipp-classen philipp-classen merged commit 3ef5f7a into ghostery:master Apr 30, 2026
5 checks passed
@philipp-classen philipp-classen deleted the fix-engine-bytes branch April 30, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 Increment patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants