feat: use actions/cache and artifacts for APM bundle with lock file hash + engine ID key#28333
Merged
feat: use actions/cache and artifacts for APM bundle with lock file hash + engine ID key#28333
Conversation
…_id key
- Add engine_id output to generate_aw_info.cjs and compiler_activation_job_builder.go
- Update apm.md: replace artifact upload/download with actions/cache save/restore
- Cache key: apm-{engine_id}-{hashFiles('.github/workflows/*.lock.yml')}
- Add sparse checkout of .github/workflows in apm job for hashFiles to work
- Skip packing on cache hit; save bundle on cache miss
- pre-agent-steps: restore from cache instead of downloading artifact
- Update golden test files with new engine_id activation output
- Recompile all 201 workflow lock files
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d58943ba-221e-4c11-80b1-91e57d1d7263
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 24, 2026 20:02
View session
Collaborator
|
@copilot keep using artifacts, as well as cache |
The apm job now saves the bundle to both cache and artifact: - Cache (actions/cache) for cross-run reuse keyed by engine_id + lock file hash - Artifact (actions/upload-artifact) for reliable same-run access In pre-agent-steps: restore from cache first; fall back to downloading the artifact if cache misses. Both paths use a unified find command to locate the .tar.gz for the apm-action restore step. Agent-Logs-Url: https://github.com/github/gh-aw/sessions/baeb4e0f-dad7-4c25-9265-c9d408c3fa1d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in 8227d6e. The Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
feat: use actions/cache for APM bundle with lock file hash + engine ID key
feat: use actions/cache and artifacts for APM bundle with lock file hash + engine ID key
Apr 24, 2026
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances workflow portability and reuse of the Microsoft APM bundle by (1) exposing the AI engine_id as an activation output and (2) transferring the APM bundle via both Actions cache (cross-run reuse) and artifacts (same-run reliability).
Changes:
- Expose
engine_idfromgenerate_aw_infoand wire it into activation job outputs. - Update shared APM workflow to restore/save the packed bundle via
actions/cacheand always upload an artifact; downstream jobs prefer cache and fall back to artifact. - Regenerate compiled workflow lock files and wasm golden fixtures to reflect the new activation output.
Show a summary per file
| File | Description |
|---|---|
actions/setup/js/generate_aw_info.cjs |
Adds engine_id as an action output alongside model. |
pkg/workflow/compiler_activation_job_builder.go |
Propagates engine_id into activation job outputs for downstream jobs. |
.github/workflows/shared/apm.md |
Implements cache+artifact strategy for APM bundle transfer and documents the cache key. |
.github/workflows/workflow-skill-extractor.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/workflow-normalizer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/workflow-health-manager.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/workflow-generator.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/weekly-safe-outputs-spec-review.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/weekly-issue-summary.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/weekly-editors-health-check.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/weekly-blog-post-writer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/video-analyzer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/update-astro.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/unbloat-docs.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/ubuntu-image-analyzer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/typist.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/tidy.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/test-workflow.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/test-quality-sentinel.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/test-project-url-default.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/test-dispatcher.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/test-create-pr-error-handling.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/terminal-stylist.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/technical-doc-writer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/super-linter.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/sub-issue-closer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/step-name-alignment.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/static-analysis-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/stale-repo-identifier.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/spec-librarian.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/spec-extractor.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/spec-enforcer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-workflow-call.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-workflow-call-with-inputs.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-update-cross-repo-pr.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-test-tools.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-temporary-id.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-service-ports.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-project.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-opencode.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-multi-pr.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-gemini.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-crush.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-create-cross-repo-pr.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-copilot.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-copilot-arm.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-codex.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-claude.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output and updated inlined APM cache+artifact steps. |
.github/workflows/smoke-ci.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-call-workflow.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-agent-scoped-approved.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-agent-public-none.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-agent-public-approved.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-agent-all-none.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/smoke-agent-all-merged.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/slide-deck-maintainer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/sergo.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/semantic-function-refactor.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/security-review.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/security-compliance.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/scout.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/schema-feature-coverage.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/schema-consistency-checker.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/safe-output-health.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/research.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/repository-quality-improver.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/repo-tree-map.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/repo-audit-analyzer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/release.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/refiner.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/refactoring-cadence.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/q.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/python-data-charts.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/prompt-clustering-analysis.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/pr-triage-agent.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/pr-nitpick-reviewer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/poem-bot.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/plan.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/pdf-summary.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/org-health-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/notion-issue-summary.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/metrics-collector.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/mergefest.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/mcp-inspector.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/lockfile-stats.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/layout-spec-maintainer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/jsweep.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/issue-triage-agent.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/issue-monster.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/issue-arborist.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/instructions-janitor.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/hourly-ci-cleaner.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/hippo-embed.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/grumpy-reviewer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/gpclean.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/go-pattern-detector.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/go-logger.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/go-fan.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/glossary-maintainer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/github-remote-mcp-auth-test.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/github-mcp-tools-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/github-mcp-structural-analysis.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/functional-pragmatist.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/firewall.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/firewall-escape.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/example-workflow-analyzer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/example-permissions-warning.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/duplicate-code-detector.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/draft-pr-cleanup.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/docs-noob-tester.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/discussion-task-miner.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/dictation-prompt.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/developer-docs-consolidator.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/dev.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/dev-hawk.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/design-decision-gate.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/dependabot-go-checker.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/dependabot-burner.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/delight.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/deep-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/dead-code-remover.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-workflow-updater.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-token-consumption-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-testify-uber-super-expert.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-team-status.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-team-evolution-insights.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-syntax-error-quality.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-skill-optimizer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-semgrep-scan.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-security-red-team.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-secrets-analysis.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-safe-outputs-conformance.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-safe-output-optimizer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-safe-output-integrator.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-repo-chronicle.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-rendering-scripts-verifier.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-regulatory.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-performance-summary.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-otel-instrumentation-advisor.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-observability-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-news.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-multi-device-docs-tester.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-mcp-concurrency-analysis.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-malicious-code-scan.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-issues-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-integrity-analysis.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-hippo-learn.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-function-namer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-firewall-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-file-diet.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-fact.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-doc-updater.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-doc-healer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-compiler-quality.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-community-attribution.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-code-metrics.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-cli-tools-tester.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-cli-performance.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-choice-test.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-aw-cross-repo-compile-check.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-astrostylelite-markdown-spellcheck.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-assign-issue-to-user.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/daily-architecture-diagram.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/craft.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-token-optimizer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-token-audit.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-session-insights.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-pr-prompt-analysis.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-pr-nlp-analysis.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-pr-merged-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-opt.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-cli-deep-research.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/copilot-agent-analysis.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/contribution-check.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/constraint-solving-potd.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/commit-changes-analyzer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/codex-github-remote-mcp-test.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/code-simplifier.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/code-scanning-fixer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/cloclo.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/cli-version-checker.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/cli-consistency-checker.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/claude-code-user-docs-review.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/ci-doctor.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/ci-coach.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/changeset.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/breaking-change-checker.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/brave.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/bot-detection.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/blog-auditor.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/aw-failure-investigator.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/auto-triage-issues.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/audit-workflows.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/artifacts-summary.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/architecture-guardian.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/archie.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/approach-validator.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/api-consumption-report.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/ai-moderator.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/agentic-optimization-kit.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/agentic-observability-kit.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/agent-persona-explorer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/agent-performance-analyzer.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
.github/workflows/ace-editor.lock.yml |
Regenerated compiled workflow; includes new activation engine_id output. |
pkg/workflow/testdata/wasm_golden/WasmBinary/with-imports.golden |
Updates golden output to include activation engine_id. |
pkg/workflow/testdata/wasm_golden/WasmBinary/basic-copilot.golden |
Updates golden output to include activation engine_id. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden |
Updates golden output to include activation engine_id. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden |
Updates golden output to include activation engine_id. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden |
Updates golden output to include activation engine_id. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (2)
.github/workflows/shared/apm.md:111
- If both the cache restore and artifact download miss (or the artifact contains no
.tar.gz), thisfindwill set an emptybundlepath and the subsequentmicrosoft/apm-actionrestore will likely fail with a less actionable error. Consider validating that a bundle was found and emitting a clear failure message before invoking the restore action.
.github/workflows/shared/apm.md:90 actions/upload-artifactdefaults toif-no-files-found: warn, so ifsteps.apm_bundle_path.outputs.pathis empty/missing the workflow may succeed while producing no artifact, breaking downstream restore. Setif-no-files-found: error(or equivalent validation) to make failures explicit.
- Files reviewed: 209/209 changed files
- Comments generated: 1
Comment on lines
+81
to
+83
| - name: Find APM bundle path | ||
| id: apm_bundle_path | ||
| run: echo "path=$(find /tmp/gh-aw/apm-workspace -name '*.tar.gz' | head -1)" >> "$GITHUB_OUTPUT" |
Contributor
There was a problem hiding this comment.
Agreed — the empty bundle path is a latent risk. Using find ... | head -1 without a guard means downstream steps could silently proceed with an empty variable. A [ -z "$BUNDLE_PATH" ] && exit 1 guard would be a minimal fix.
📰 BREAKING: Report filed by Smoke Copilot · ● 946.1K
…che-setup # Conflicts: # .github/workflows/daily-fact.lock.yml # .github/workflows/daily-observability-report.lock.yml # .github/workflows/duplicate-code-detector.lock.yml # .github/workflows/grumpy-reviewer.lock.yml # .github/workflows/issue-arborist.lock.yml # .github/workflows/schema-feature-coverage.lock.yml # .github/workflows/smoke-call-workflow.lock.yml # .github/workflows/smoke-claude.lock.yml # .github/workflows/smoke-codex.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/aaff8d4c-4443-41bc-b685-48bca978d3d1 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Merged Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
|
@copilot review changes in apm.md |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/256b0598-0435-4534-996d-3ff0b8ed6cac Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Addressed in dd7c51a. The two run: |
bundle=$(find /tmp/gh-aw/apm-workspace -name '*.tar.gz' | head -1)
if [ -z "$bundle" ]; then
echo "::error::APM bundle not found in /tmp/gh-aw/apm-workspace"
exit 1
fi
echo "path=$bundle" >> "$GITHUB_OUTPUT"Same guard added to the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
|
@copilot merge main and recompile |
…che-setup # Conflicts: # .github/workflows/daily-fact.lock.yml # .github/workflows/smoke-call-workflow.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/312249f3-c27d-4e6e-aeff-ea5b025407dd Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in f6407db. Merged Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
Contributor
|
|
Contributor
|
🚀 Smoke OpenCode MISSION COMPLETE! OpenCode delivered. 🔥 |
Contributor
|
|
Contributor
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Contributor
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Contributor
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
Contributor
|
Smoke test: FAIL
Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "ab.chatgpt.com"
- "chatgpt.com"See Network Configuration for more information.
|
Contributor
Smoke Test Results - Run §24911755809
Overall: PASS ✅ · PR author:
|
Contributor
Comment MemoryNote This comment is managed by comment memory. It stores persistent context for this thread in the code block at the top of this comment.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Smoke test code review complete. The PR consistently adds engine_id to workflow outputs across all lock files — a clean, uniform change that improves observability. No functional issues found.
📰 BREAKING: Report filed by Smoke Copilot · ● 946.1K
Contributor
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
|
Smoke Test 24911755793 — Claude engine validation results: Core: ✅ GitHub MCP ✅ GH CLI ✅ Serena ✅ Make Build ✅ Playwright ✅ Tavily ✅ File Write ✅ Bash ✅ Discussion ❌ AW Status ✅ Slack ✅ CodeScan Overall: PARTIAL — AW MCP status tool unavailable; all else passed.
|
Contributor
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal! Run 24911755793 validated the Claude engine is functioning correctly across all tool categories.
💥 [THE END] — Illustrated by Smoke Claude · ● 241K
| comment_id: ${{ steps.add-comment.outputs.comment-id }} | ||
| comment_repo: ${{ steps.add-comment.outputs.comment-repo }} | ||
| comment_url: ${{ steps.add-comment.outputs.comment-url }} | ||
| engine_id: ${{ steps.generate_aw_info.outputs.engine_id }} |
Contributor
There was a problem hiding this comment.
✅ Smoke test review comment #1 — The new engine_id output correctly propagates from generate_aw_info to the activation job outputs. This is consistent with the pattern used by the model output on the following line. Run 24911755793.
| outputs: | ||
| comment_id: "" | ||
| comment_repo: "" | ||
| engine_id: ${{ steps.generate_aw_info.outputs.engine_id }} |
Contributor
There was a problem hiding this comment.
✅ Smoke test review comment #2 — engine_id added consistently to the activation outputs here too. This enables the APM cache key to be keyed per engine type. Run 24911755793.
Contributor
|
Commit pushed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APM bundles are now transferred between jobs via both
actions/cache(for cross-run reuse) and artifacts (for reliable same-run access).Changes
New
engine_idactivation outputgenerate_aw_info.cjs: exposesengine_idviacore.setOutputalongside the existingmodeloutputcompiler_activation_job_builder.go: addsengine_id: ${{ steps.generate_aw_info.outputs.engine_id }}to the activation job outputsshared/apm.md— cache + artifact bundle transferThe
apmjob sparse-checks out.github/workflowssohashFilescan compute the lock file hash, then saves the bundle to both cache and artifact on every run.Cache key:
apm-{engine_id}-{hashFiles('.github/workflows/*.lock.yml')}All 201 lock files recompiled.
✨ PR Review Safe Output Test - Run 24911755793
Changeset
engine_idfrom activation outputs for shared workflow cache keys.Warning
Firewall blocked 3 domains
The following domains were blocked by the firewall during workflow execution:
ab.chatgpt.comchatgpt.cominvalid.example.invalidSee Network Configuration for more information.