docs: remove trailing whitespace from README.md#2384
Closed
srpatcha wants to merge 4 commits intogithub:mainfrom
Closed
docs: remove trailing whitespace from README.md#2384srpatcha wants to merge 4 commits intogithub:mainfrom
srpatcha wants to merge 4 commits intogithub:mainfrom
Conversation
Add comprehensive release management tools including: - CreateRelease: create releases with draft/prerelease support - UpdateRelease: modify existing releases - DeleteRelease: remove releases - GetReleaseByID: fetch specific release details - ListReleaseAssets: list assets for a release - DeleteReleaseAsset: remove release assets - Tag name validation using regex Signed-off-by: Srikanth Patchava <spatchava@meta.com>
Fix ListReleases to use ghErrors.NewGitHubAPIErrorResponse instead of returning a raw Go error via fmt.Errorf. This ensures API errors are properly surfaced as tool result errors to the user, consistent with the pattern used in other tools like ListGists. Signed-off-by: Srikanth Patchava <spatchava@meta.com>
Add comprehensive Go tests covering: - CreateRelease: success, draft/prerelease, missing tag, invalid tag - UpdateRelease: success, missing release_id - DeleteRelease: successful deletion - GetReleaseByID: successful retrieval - ListReleaseAssets: successful listing - DeleteReleaseAsset: successful deletion - isValidTagName: valid and invalid tag names Signed-off-by: Srikanth Patchava <spatchava@meta.com>
Collaborator
|
Closing because the PR title/body describe a trivial README whitespace change, but the diff actually introduces a large unrelated releases-management feature and tests. Please reopen as a focused PR with an accurate title/body and the usual generated docs/toolsnaps if you want the releases work reviewed on its own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
docs: remove trailing whitespace from README.md
Signed-off with GPG.