`2.1.16` tries to rename all repos to the same name

[paddyroddy]

Problem Description

What is actually happening

I am using @renovatebot to manage my dependencies and our GitHub Action got upgraded from 2.1.14 to 2.1.16 in UCL-MIRSG/.github@78f2369. At this point, the workflow began failing.

It looks like it is going through every repo and trying to rename it to terraform-harvester-modules. It then errors because https://github.com/UCL-MIRSG/terraform-harvester-modules already exists. I have no idea why is this happening, or why that particular repo was selected. For now I have downgraded to 2.1.14.

I'll attach the full logs in a comment underneath.

What is the expected behavior

The upgrading version shouldn't have broken the workflow.

Error output, if available

The relevant bit of the log is

2025-03-03T01:32:26.3406001Z �[34mDEBUG�[39m (terraform-harvester-modules): �[36mGitHub request: PATCH https://api.github.com/repos/UCL-MIRSG/medical-imaging-outreach - 422�[39m
2025-03-03T01:32:26.3407367Z     allow_auto_merge: true
2025-03-03T01:32:26.3407942Z     allow_merge_commit: false
2025-03-03T01:32:26.3408548Z     allow_rebase_merge: false
2025-03-03T01:32:26.3409160Z     delete_branch_on_merge: true
2025-03-03T01:32:26.3409695Z     has_discussions: false
2025-03-03T01:32:26.3410248Z     has_downloads: false
2025-03-03T01:32:26.3410742Z     has_wiki: false
2025-03-03T01:32:26.3411237Z     squash_merge_commit_message: "PR_BODY"
2025-03-03T01:32:26.3411974Z     squash_merge_commit_title: "PR_TITLE"
2025-03-03T01:32:26.3412543Z     org: "UCL-MIRSG"
2025-03-03T01:32:26.3425160Z �[31mERROR�[39m (probot): �[36m Error {"name":"HttpError","status":422,"response":{"url":"https://api.github.com/repos/UCL-MIRSG/medical-imaging-outreach","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset","content-length":"245","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 03 Mar 2025 01:32:26 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-accepted-github-permissions":"administration=write","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-api-version-selected":"2022-11-28","x-github-media-type":"github.v3; param=nebula-preview; format=json","x-github-request-id":"4044:EF720:443A7B:89B495:67C506A9","x-ratelimit-limit":"9350","x-ratelimit-remaining":"9037","x-ratelimit-reset":"1740969051","x-ratelimit-resource":"core","x-ratelimit-used":"313","x-xss-protection":"0"},"data":{"message":"Validation Failed","errors":[{"resource":"Repository","code":"custom","field":"name","message":"name already exists on this account"}],"documentation_url":"https://docs.github.com/rest/repos/repos#update-a-repository","status":"422"}},"request":{"method":"PATCH","url":"https://api.github.com/repos/UCL-MIRSG/medical-imaging-outreach","headers":{"accept":"application/vnd.github.nebula-preview+json","user-agent":"probot/12.4.0 octokit-core.js/3.6.0 Node.js/20.18.3 (linux; x64)","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{\"allow_auto_merge\":true,\"allow_merge_commit\":false,\"allow_rebase_merge\":false,\"delete_branch_on_merge\":true,\"has_discussions\":false,\"has_downloads\":false,\"has_wiki\":false,\"squash_merge_commit_message\":\"PR_BODY\",\"squash_merge_commit_title\":\"PR_TITLE\",\"name\":\"terraform-harvester-modules\",\"org\":\"UCL-MIRSG\"}","request":{"retryCount":1}}}�[39m

Context

Are you using the hosted instance of probot/settings or running your own?

Running in GitHub Actions.

If running your own instance, are you using it with github.com or GitHub Enterprise?

Version of probot/settings

Version of GitHub Enterprise

[paddyroddy]

0_safe-settings-sync.txt

[stokkie90]

@paddyroddy Had indeed the same issue when working on this version. This line seems to fix it: https://github.com/github/safe-settings/pull/767/files#diff-cb055c8e3497e3772fc444a77c4aed8483453e7580ffe7ddb223bdffaff43c57R306

[dolan-a]

The fix @stokkie90 mentioned also fixed the issue for me. I guess we can wait for #767 to get merged to resolve #775. Thanks

[dolan-a]

If anyone is impatient like I was (I wanted to use the new EXTERNALLY_DEFINED feature), I added this to my GHA running safe-settings (targeting commit 0cb33c8ab623bf8e74c2697ad21118195892c4c7):

      - run: 'sed -i "303s/assign(repoConfig/assign({}, repoConfig/" ./lib/settings.js'
        working-directory: ${{ env.SAFE_SETTINGS_CODE_DIR }}

[JakubBiel]

Do we know which version introduced this issue? 2.15 or 2.16?

[klutchell]

I actually fixed this exact issue with this commit, now merged.

[decyjphr]

Closing this as I tested PR #806