Skip to content

fix: agent generate config error#1450

Merged
genquan9 merged 2 commits intogoogle:mainfrom
simonwei97:agent-generate-config-err
Jun 17, 2025
Merged

fix: agent generate config error#1450
genquan9 merged 2 commits intogoogle:mainfrom
simonwei97:agent-generate-config-err

Conversation

@simonwei97
Copy link
Copy Markdown
Contributor

Fixes: #1302

Previous PR(#1305) has been reverted by commit 1cfc555. So I submit new PR for bug fix.

@genquan9

Copy link
Copy Markdown
Contributor

@genquan9 genquan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@genquan9 genquan9 merged commit 694b712 into google:main Jun 17, 2025
9 checks passed
@genquan9 genquan9 added the ready to pull [Status] This PR is ready to be imported back to Google label Jun 18, 2025
hangfei added a commit that referenced this pull request Jun 18, 2025
@genquan9
Copy link
Copy Markdown
Contributor

There were some issues in the process when merge the PR. Could you send a new PR? Sorry for the inconveniences, and thanks for your help!

@simonwei97 simonwei97 deleted the agent-generate-config-err branch June 19, 2025 01:29
@simonwei97
Copy link
Copy Markdown
Contributor Author

There were some issues in the process when merge the PR. Could you send a new PR? Sorry for the inconveniences, and thanks for your help!

ok.

copybara-service bot pushed a commit that referenced this pull request Jun 25, 2025
Merge #1509

Fixs: #1302

Previous PR: #1450

FUTURE_COPYBARA_INTEGRATE_REVIEW=#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 774803187
copybara-service bot pushed a commit that referenced this pull request Jun 26, 2025
Merge #1509

Fixs: #1302

Previous PR: #1450

FUTURE_COPYBARA_INTEGRATE_REVIEW=#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 774803187
copybara-service bot pushed a commit that referenced this pull request Jun 26, 2025
Merge #1509

Fixs: #1302

Previous PR: #1450

COPYBARA_INTEGRATE_REVIEW=#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 775903671
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
Merge google#1509

Fixs: google#1302

Previous PR: google#1450

COPYBARA_INTEGRATE_REVIEW=google#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 775903671
seanzhou1023 pushed a commit to soundTricker/adk-python that referenced this pull request Jul 11, 2025
seanzhou1023 pushed a commit to soundTricker/adk-python that referenced this pull request Jul 11, 2025
Merge google#1509

Fixs: google#1302

Previous PR: google#1450

COPYBARA_INTEGRATE_REVIEW=google#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 775903671
pandasanjay pushed a commit to pandasanjay/adk-python that referenced this pull request Jul 28, 2025
pandasanjay pushed a commit to pandasanjay/adk-python that referenced this pull request Jul 28, 2025
Merge google#1509

Fixs: google#1302

Previous PR: google#1450

COPYBARA_INTEGRATE_REVIEW=google#1509 from simonwei97:fix/litellm-gen-config-converting-err 3120887
PiperOrigin-RevId: 775903671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull [Status] This PR is ready to be imported back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LLM Generation Config(generate_content_config) does not work.

2 participants