Merged
Conversation
Collaborator
|
@genquan9 Could you help review this change? |
genquan9
reviewed
Jun 13, 2025
genquan9
reviewed
Jun 13, 2025
genquan9
reviewed
Jun 13, 2025
genquan9
reviewed
Jun 13, 2025
Contributor
genquan9
left a comment
genquan9
left a comment
There was a problem hiding this comment.
Thanks a lot for the help!
The change is great in general!
I only added minor comments.
Could you resolve the comments?
Contributor
Author
@genquan9 Thanks for your suggestion. I fixed the problem mentioned in above comments. |
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
* fix: agent generate config err * fix: resovle comment --------- Co-authored-by: Hangfei Lin <hangfei@google.com> Co-authored-by: genquan9 <49327371+genquan9@users.noreply.github.com>
seanzhou1023
pushed a commit
to soundTricker/adk-python
that referenced
this pull request
Jul 11, 2025
* fix: agent generate config err * fix: resovle comment --------- Co-authored-by: Hangfei Lin <hangfei@google.com> Co-authored-by: genquan9 <49327371+genquan9@users.noreply.github.com>
pandasanjay
pushed a commit
to pandasanjay/adk-python
that referenced
this pull request
Jul 28, 2025
* fix: agent generate config err * fix: resovle comment --------- Co-authored-by: Hangfei Lin <hangfei@google.com> Co-authored-by: genquan9 <49327371+genquan9@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Update
I modified both
_get_completion_inputsandgenerate_content_asyncfunctions, the associate file issrc/google/adk/models/lite_llm.py.Test Case
unittests
json.test_generate_content_async(same codeL430-L507)test_get_completion_inputs_generation_paramsfor func_get_completion_inputsFixes: #1302