Skip to content

Fix underflow in NUQ ClusterCost() #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 25, 2024
Merged

Fix underflow in NUQ ClusterCost() #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions compression/nuq-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,8 @@ class NuqClustering {
// Callers are responsible for ignoring lanes where last < first.
HWY_DASSERT(first < kGroupSize);
HWY_DASSERT(last < kGroupSize);
const size_t len = last - first + 1;
const hn::Vec<DF> vlen =
hn::Iota(df, static_cast<float>(static_cast<int>(len)));
const int len = static_cast<int>(last) - static_cast<int>(first) + 1;
const hn::Vec<DF> vlen = hn::Iota(df, static_cast<float>(len));

const hn::Vec<DF> u_lo = hn::Set(df, cumsum_[first]);
const hn::Vec<DF> u_lo2 = hn::Set(df, cumsum2_[first]);
Expand Down Expand Up @@ -204,7 +203,7 @@ class NuqClustering {
for (size_t num_clusters = 1; num_clusters < kClusters; ++num_clusters) {
// For each batch starting at `last`, one per lane:
for (size_t last = 0; last < kGroupSize; last += N) {
VF min = cc(df, 0, last);
VF min = hn::LoadU(df, &D(0, last));
VI arg = hn::Zero(di);
// For each j (start of rightmost cluster):
VI vj = k1;
Expand Down