Simplify threading: remove the use of inner_pool.#167
Merged
copybara-service[bot] merged 1 commit intogoogle:devfrom Apr 30, 2024
Merged
Simplify threading: remove the use of inner_pool.#167copybara-service[bot] merged 1 commit intogoogle:devfrom
copybara-service[bot] merged 1 commit intogoogle:devfrom
Conversation
We only used inner_pool in the prefill FFW function, and there we
can achieve sufficient parallelism on the rows of the matrix-vector
multiplications.
Benchmark results on a 1600-token summarization task:
```
Prefill speed
Num threads BEFORE AFTER
4 9.24 t/s 9.76 t/s
18 31.41 t/s 31.16 t/s
32 31.41 t/s 45.13 t/s
64 31.03 t/s 57.85 t/s
```
jan-wassenberg
approved these changes
Apr 29, 2024
Member
jan-wassenberg
left a comment
There was a problem hiding this comment.
Nice simplification, thank you @szabadka !
Was talking today with Austin about using matmul in Prefill, that will also help speed this up.
Unrelatedly, what do you think of moving some of the function call arguments into a struct, for example AuxOut(layers_output) and/or Sampling(temp/gen)?
Collaborator
Author
Yes, that could be useful, these functions have quite a few arguments. |
Member
|
Will do :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only used inner_pool in the prefill FFW function, and there we can achieve sufficient parallelism on the rows of the matrix-vector multiplications.
Benchmark results on a 1600-token summarization task: