Open
Conversation
vvidic
force-pushed
the
remove-cli
branch
6 times, most recently
from
4189057 to
59a8f2e
Compare
burgerdev
approved these changes
Apr 8, 2026
kokoro/docker/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM docker.io/library/debian:bullseye AS build | |||
| FROM docker.io/library/debian:latest AS build | |||
Collaborator
There was a problem hiding this comment.
Is using latest a good idea? I'd think we might want to be deliberate about updating the version here. For reproducibility, we might even want to pin the version/digest.
Collaborator
Author
There was a problem hiding this comment.
Updated to trixie as the current stable version.
kokoro/rodete/debian_cargo.sh
Outdated
Comment on lines
+22
to
+35
| fix_version() { | ||
| pkg="librust-$1-dev" | ||
| ver=$(dpkg-query -W -f '${Version}\n' "$pkg") | ||
| if [ "$ver" ]; then | ||
| ver=${ver%%-*} | ||
| sed -i "/^$1/s/= \"[.0-9]*\"/= \"$ver\"/" rust/Cargo.toml | ||
| fi | ||
| } | ||
|
|
||
| fix_version base64 | ||
| fix_version hex-literal | ||
| fix_version tempfile | ||
| fix_version yaml-rust2 | ||
| rm -f rust/Cargo.lock |
Collaborator
There was a problem hiding this comment.
Could we somehow align the versions in the Cargo.lock and the ones from Debian more permanently?
Collaborator
Author
There was a problem hiding this comment.
Updated versions in Cargo.toml so they work with current Debian packages.
Keep README.md until we create a manpage for CLI. Also update Docker image to use the Rust CLI. Closes google#187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep README.md until we create a manpage for CLI.
Closes #187